-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS][AdManager][Banner] An ad is not rendered properly #189
Conversation
…hat fix 1x1 issue
@@ -108,6 +108,9 @@ class BannerController: UIViewController, GADBannerViewDelegate, MPAdViewDelegat | |||
|
|||
func adViewDidReceiveAd(_ bannerView: GADBannerView) { | |||
print("adViewDidReceiveAd") | |||
|
|||
self.dfpBanner.resize(bannerView.adSize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be documented here http://prebid.org/prebid-mobile/pbm-api/ios/pbm-bannerad-ios.html
to include adManager and the implementation logics like these to address specific mediation partner issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix seems to be fine. 👍 I agree with @ppuviarasu 's comment as well.
- resize E-E test was improved
The latest update to PR has the next logic:
Please note that it is Utility function that is supposed to call it from the client code when it is necessary |
|
||
func findSizeInWebViewAsync(uiWebView: UIWebView, completion: @escaping (CGSize?) -> Void) { | ||
|
||
Timer.scheduledTimer(withTimeInterval: 0.1, repeats: true) { (timer) in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API only works for iOS 10 & above and not for iOS 9. Since we are downgrading to iOS 9, can you fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will upgrade the PR.
@ppuviarasu, I have updated the PR. |
@ppuviarasu, I have finished sanity checks and it seems that it is workable fix. Could you please review this PR? |
docs PR prebid/prebid.github.io#1352 |
Issue #175
API:
Example: