Skip to content

Commit

Permalink
Fixes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
rpanchyk committed Jun 15, 2021
1 parent 77ff45c commit 13d3365
Showing 1 changed file with 0 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import java.util.function.Function;

import static java.util.Arrays.asList;
import static java.util.Collections.emptyList;
import static java.util.Collections.singletonList;
import static java.util.function.Function.identity;
import static org.assertj.core.api.Assertions.assertThat;
Expand All @@ -51,21 +50,6 @@ public void creationShouldFailOnInvalidEndpointUrl() {
.withMessage("URL supplied is not valid: invalid_url");
}

@Test
public void makeHttpRequestsShouldReturnErrorIfImpressionListSizeIsZero() {
// given
final BidRequest bidRequest = BidRequest.builder()
.imp(emptyList())
.build();

// when
final Result<List<HttpRequest<Void>>> result = adgenerationBidder.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).hasSize(1)
.containsOnly(BidderError.badInput("No impression in the bid request"));
}

@Test
public void makeHttpRequestsShouldReturnErrorIfImpExtCouldNotBeParsed() {
// given
Expand Down

0 comments on commit 13d3365

Please sign in to comment.