Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add modifying of VAST for video bids and add validation (#1081)
* Add modifying of VAST for video bids and add validation - Add validation for Video bids. `bid.adm` or `bid.nurl` needs to be present - This case now, is not possible `<VASTAdTagURI><![CDATA[null]]></VASTAdTagURI>` - Bid adm will be updated as cache. (see prebid/prebid-server#1015) - Bid type is defined by bidder, not our (`imp.video != null`, etc) checks. For example Appnexus use `bid.ext.appnexus.bid_ad_type` to define it. (that's why there are a lot of changed cache jsons. Also add ordering for tests) Refactored a bit. - Removed confusing maps - Removed confusing checks - Removed several imp to bid matching Possible improvements (in another ticket bc current PR is too large) - Extract more event URL to another class - Use bidInfo in BidResponseCreator for BidResponse * Merged master and fixed corresponding imp can't be null * Fix after review. (without changing localhost/event) * Use placeholders in test resources instead of concrete urls where possible (#1084) * Fix tests and remove ordering * Replace usage of Wiremock EqualToJsonPattern with custom implementation to prevent incorrect json comparison * fix openx * Use equalToBidCacheRequest for consistency and add openrtbCacheDebugComparator() when debug is used (fix flaky tests) * Remove redundant code Co-authored-by: Sergii Chernysh <schernysh@users.noreply.github.com> Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com>
- Loading branch information