Add modifying of VAST for video bids and add validation #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add validation for Video bids. `bid.adm` or `bid.nurl` needs to be present - This case now, is not possible `<VASTAdTagURI><![CDATA[null]]></VASTAdTagURI>` - Bid adm will be updated as cache. (see prebid/prebid-server#1015) - Bid type is defined by bidder, not our (`imp.video != null`, etc) checks. For example Appnexus use `bid.ext.appnexus.bid_ad_type` to define it. (that's why there are a lot of changed cache jsons. Also add ordering for tests) Refactored a bit. - Removed confusing maps - Removed confusing checks - Removed several imp to bid matching Possible improvements (in another ticket bc current PR is too large) - Extract more event URL to another class - Use bidInfo in BidResponseCreator for BidResponse
…oring # Conflicts: # src/main/java/org/prebid/server/validation/ResponseBidValidator.java # src/test/java/org/prebid/server/validation/ResponseBidValidatorTest.java
schernysh
reviewed
Dec 21, 2020
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
...s/org/prebid/server/it/openrtb2/rubicon_appnexus/test-auction-rubicon-appnexus-response.json
Outdated
Show resolved
Hide resolved
…on to prevent incorrect json comparison
…omparator() when debug is used (fix flaky tests)
…oring Update tests. Remove unnecessary code
…oring # Conflicts: # src/main/java/org/prebid/server/cache/CacheService.java # src/test/java/org/prebid/server/cache/CacheServiceTest.java
rpanchyk
approved these changes
Feb 23, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
* Add modifying of VAST for video bids and add validation - Add validation for Video bids. `bid.adm` or `bid.nurl` needs to be present - This case now, is not possible `<VASTAdTagURI><![CDATA[null]]></VASTAdTagURI>` - Bid adm will be updated as cache. (see prebid/prebid-server#1015) - Bid type is defined by bidder, not our (`imp.video != null`, etc) checks. For example Appnexus use `bid.ext.appnexus.bid_ad_type` to define it. (that's why there are a lot of changed cache jsons. Also add ordering for tests) Refactored a bit. - Removed confusing maps - Removed confusing checks - Removed several imp to bid matching Possible improvements (in another ticket bc current PR is too large) - Extract more event URL to another class - Use bidInfo in BidResponseCreator for BidResponse * Merged master and fixed corresponding imp can't be null * Fix after review. (without changing localhost/event) * Use placeholders in test resources instead of concrete urls where possible (#1084) * Fix tests and remove ordering * Replace usage of Wiremock EqualToJsonPattern with custom implementation to prevent incorrect json comparison * fix openx * Use equalToBidCacheRequest for consistency and add openrtbCacheDebugComparator() when debug is used (fix flaky tests) * Remove redundant code Co-authored-by: Sergii Chernysh <schernysh@users.noreply.github.com> Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com>
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Add modifying of VAST for video bids and add validation - Add validation for Video bids. `bid.adm` or `bid.nurl` needs to be present - This case now, is not possible `<VASTAdTagURI><![CDATA[null]]></VASTAdTagURI>` - Bid adm will be updated as cache. (see prebid/prebid-server#1015) - Bid type is defined by bidder, not our (`imp.video != null`, etc) checks. For example Appnexus use `bid.ext.appnexus.bid_ad_type` to define it. (that's why there are a lot of changed cache jsons. Also add ordering for tests) Refactored a bit. - Removed confusing maps - Removed confusing checks - Removed several imp to bid matching Possible improvements (in another ticket bc current PR is too large) - Extract more event URL to another class - Use bidInfo in BidResponseCreator for BidResponse * Merged master and fixed corresponding imp can't be null * Fix after review. (without changing localhost/event) * Use placeholders in test resources instead of concrete urls where possible (#1084) * Fix tests and remove ordering * Replace usage of Wiremock EqualToJsonPattern with custom implementation to prevent incorrect json comparison * fix openx * Use equalToBidCacheRequest for consistency and add openrtbCacheDebugComparator() when debug is used (fix flaky tests) * Remove redundant code Co-authored-by: Sergii Chernysh <schernysh@users.noreply.github.com> Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com>
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Add modifying of VAST for video bids and add validation - Add validation for Video bids. `bid.adm` or `bid.nurl` needs to be present - This case now, is not possible `<VASTAdTagURI><![CDATA[null]]></VASTAdTagURI>` - Bid adm will be updated as cache. (see prebid/prebid-server#1015) - Bid type is defined by bidder, not our (`imp.video != null`, etc) checks. For example Appnexus use `bid.ext.appnexus.bid_ad_type` to define it. (that's why there are a lot of changed cache jsons. Also add ordering for tests) Refactored a bit. - Removed confusing maps - Removed confusing checks - Removed several imp to bid matching Possible improvements (in another ticket bc current PR is too large) - Extract more event URL to another class - Use bidInfo in BidResponseCreator for BidResponse * Merged master and fixed corresponding imp can't be null * Fix after review. (without changing localhost/event) * Use placeholders in test resources instead of concrete urls where possible (#1084) * Fix tests and remove ordering * Replace usage of Wiremock EqualToJsonPattern with custom implementation to prevent incorrect json comparison * fix openx * Use equalToBidCacheRequest for consistency and add openrtbCacheDebugComparator() when debug is used (fix flaky tests) * Remove redundant code Co-authored-by: Sergii Chernysh <schernysh@users.noreply.github.com> Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com>
SerhiiNahornyi
pushed a commit
that referenced
this pull request
Nov 30, 2023
Co-authored-by: Dubyk Danylo <pointbay2001@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bid.admorbid.nurlneeds to be present<VASTAdTagURI><![CDATA[null]]></VASTAdTagURI>imp.video != null, etc) checks. For example Appnexus usebid.ext.appnexus.bid_ad_typeto define it. (that's why there are a lot of changed cache jsons. Also add ordering for tests)Refactored a bit.
Possible improvements (in another ticket bc current PR is too large)