Bump httpclient from 4.5.5 to 4.5.13 #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps httpclient from 4.5.5 to 4.5.13. --- updated-dependencies: - dependency-name: org.apache.httpcomponents:httpclient dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
added 3 commits
June 7, 2021 11:28
…-httpclient-4.5.13
…-httpclient-4.5.13
SerhiiNahornyi
suggested changes
Jun 15, 2021
| if (CollectionUtils.isEmpty(request.getImp())) { | ||
| final List<Imp> imps = request.getImp(); | ||
|
|
||
| if (CollectionUtils.isEmpty(imps)) { |
There was a problem hiding this comment.
Seems it is not possible statement
| private static String resolveEndpointUrl(String url) { | ||
| final URIBuilder uriBuilder; | ||
| try { | ||
| uriBuilder = new URIBuilder(HttpUtil.validateUrl(Objects.requireNonNull(url))); |
There was a problem hiding this comment.
Seems we will already have validation for url while creating uri builder
There was a problem hiding this comment.
i'd say new URI(string) doesn't cover invalid url as new URL(url) does.
So, org.prebid.server.bidder.amx.AmxBidderTest#creationShouldFailOnInvalidEndpointUrl will fail.
SerhiiNahornyi
previously approved these changes
Jun 15, 2021
SerhiiNahornyi
approved these changes
Jun 16, 2021
dependabot
bot
deleted the
dependabot/maven/org.apache.httpcomponents-httpclient-4.5.13
branch
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
* Bump httpclient from 4.5.5 to 4.5.13 Bumps httpclient from 4.5.5 to 4.5.13. --- updated-dependencies: - dependency-name: org.apache.httpcomponents:httpclient dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Fixes after upgrade * Fixes after review * Fixes after review Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com>
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Bump httpclient from 4.5.5 to 4.5.13 Bumps httpclient from 4.5.5 to 4.5.13. --- updated-dependencies: - dependency-name: org.apache.httpcomponents:httpclient dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Fixes after upgrade * Fixes after review * Fixes after review Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com>
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Bump httpclient from 4.5.5 to 4.5.13 Bumps httpclient from 4.5.5 to 4.5.13. --- updated-dependencies: - dependency-name: org.apache.httpcomponents:httpclient dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Fixes after upgrade * Fixes after review * Fixes after review Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps httpclient from 4.5.5 to 4.5.13.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.