Add PG tests infrastructure #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hupaloo
requested review from
Net-burst,
And1sS,
rpanchyk,
mtuchkova and
SerhiiNahornyi
hupaloo
force-pushed
the
add-pg-tests-infrastructure
branch
2 times, most recently
from
cdc197d to
2ec78aa
Compare
mtuchkova
reviewed
Nov 18, 2021
| static void waitUntil(Closure closure, long timeout = 1000, long pollInterval = 100) { | ||
| with().pollDelay(0, MILLISECONDS) | ||
| .pollInterval(pollInterval, MILLISECONDS) | ||
| .await() |
There was a problem hiding this comment.
Why do you need the await() method here?
There was a problem hiding this comment.
That method don't do anything and just return this, but it is used to enhance the readability of test conditions
| @@ -32,4 +34,12 @@ class PBSUtils { | |||
| static String getRandomString(int stringLength = 20) { | |||
| RandomStringUtils.randomAlphanumeric(stringLength) | |||
| } | |||
|
|
|||
| static void waitUntil(Closure closure, long timeout = 1000, long pollInterval = 100) { | |||
There was a problem hiding this comment.
It looks like the functionality of the checkRequestCount method is duplicated, so you can remove it. Or use it instead of the given method
| reset(USER_DETAILS_ENDPOINT_PATH) | ||
| } | ||
|
|
||
| void setResponse() { |
There was a problem hiding this comment.
Please add Override annotation where necessary for better readability
| } | ||
|
|
||
| void setUserDataResponse(UserDetailsResponse userDataResponse, HttpStatusCode httpStatusCode = OK_200) { | ||
| resetUserDetailsEndpoint() |
There was a problem hiding this comment.
Why are you using reset here? There were no expectations set for this endpoint before.
There was a problem hiding this comment.
That is an infrastructure PR, expectations are set in the test specs from other PG PRs (e.g. in some test methods from UserDetailsSpec, #1590)
* Add PG tests for Alert, Currency, Plans, Register services * Add currency conversion rates mock; fix CurrencySpec * Moved setting bid request and response to the setup() * Use soft assert where needed Co-authored-by: mhupalo <mhupalo@rubiconproject.com>
* Add PG tests to cover auction and tokens * Removed setting bid response where it doesn't matter * Use soft assert where needed; parametrization style updated Co-authored-by: mhupalo <mhupalo@rubiconproject.com>
* Add PG bidder request, bid response, user details specs * Resolve PR remarks * Use soft assert where needed Co-authored-by: mhupalo <mhupalo@rubiconproject.com>
* Add PG report, targeting specs * Resolve PR remarks * Add test case to cover domain targeting bug * Add test cases to cover scalar and array inputs by site/user first party data, bidder params * Add test case to cover NPE is not thrown by site/user first party data Co-authored-by: mhupalo <mhupalo@rubiconproject.com> Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com>
Net-burst
force-pushed
the
add-pg-tests-infrastructure
branch
from
6e0885c to
054c4d9
Compare
Net-burst
force-pushed
the
add-pg-tests-infrastructure
branch
from
b044b51 to
c39af80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infrastructure before adding tests on PBS PG functionality