Add PG tests to cover auction and tokens #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hupaloo
requested review from
Net-burst,
And1sS,
rpanchyk,
mtuchkova and
SerhiiNahornyi
rpanchyk
approved these changes
Nov 29, 2021
mtuchkova
approved these changes
Dec 14, 2021
| assert sentToBidder?.size() == lineItemCount | ||
| assert sentToBidder.sort() == lineItemIds.sort() | ||
|
|
||
| def sentToBidderAsTopMatch = auctionResponse.ext?.debug?.pgmetrics?.sentToBidderAsTopMatch?.get(GENERIC.value) |
There was a problem hiding this comment.
Can we replace the key in sentToBidderAsTopMatch with BidderName?
There was a problem hiding this comment.
No, it may be used bidder alias in the request to PBS (it may be any string).
|
|
||
| and: "Bid response" | ||
| def bidResponse = BidResponse.getDefaultBidResponse(bidRequest) | ||
| bidder.setResponse(bidRequest.id, bidResponse) |
There was a problem hiding this comment.
You can avoid setting the default response from the bidder
Net-burst
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Add PG tests to cover auction and tokens * Removed setting bid response where it doesn't matter * Use soft assert where needed; parametrization style updated Co-authored-by: mhupalo <mhupalo@rubiconproject.com>
Net-burst
added a commit
that referenced
this pull request
Feb 10, 2022
* Add PG tests infrastructure * Add cleanup after spec * Remove checkRequestCount method; add override annotation for some methods * Add PG tests for alert, currency, plans, register services (#1582) * Add PG tests for Alert, Currency, Plans, Register services * Add currency conversion rates mock; fix CurrencySpec * Moved setting bid request and response to the setup() * Use soft assert where needed Co-authored-by: mhupalo <mhupalo@rubiconproject.com> * Add PG tests to cover auction and tokens (#1589) * Add PG tests to cover auction and tokens * Removed setting bid response where it doesn't matter * Use soft assert where needed; parametrization style updated Co-authored-by: mhupalo <mhupalo@rubiconproject.com> * Add PG bidder request, bid response, user details specs (#1590) * Add PG bidder request, bid response, user details specs * Resolve PR remarks * Use soft assert where needed Co-authored-by: mhupalo <mhupalo@rubiconproject.com> * Add PG report, targeting specs (#1591) * Add PG report, targeting specs * Resolve PR remarks * Add test case to cover domain targeting bug * Add test cases to cover scalar and array inputs by site/user first party data, bidder params * Add test case to cover NPE is not thrown by site/user first party data Co-authored-by: mhupalo <mhupalo@rubiconproject.com> Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com> * Minor refactoring * Add cleanup steps after each test class * Change fetching PG properties, add waiters on line items fetch * Minor style fix Co-authored-by: mhupalo <mhupalo@rubiconproject.com> Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com> Co-authored-by: Oleksandr Zhevedenko <net.burst.mail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for PG auction, tokens
Not only those PG tests, but all (also from other PRs) have passed
[WARNING] Tests run: 246, Failures: 0, Errors: 0, Skipped: 10
[INFO] prebid-server ...................................... SUCCESS [06:02 min]