S3 application settings #3418
S3 application settings #3418
Conversation
This reverts commit 31febb4.
…application-settings/copy
|
@muuki88 When you have time, could you please approve this change? 🙂 |
src/main/java/org/prebid/server/spring/config/SettingsConfiguration.java
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/storage/StoredResponseS3Spec.groovy
Show resolved
Hide resolved
|
|
||
| // then | ||
|
|
||
| result.onComplete(context.failing(cause -> { |
There was a problem hiding this comment.
Will the test timeout or give a proper error message if it wouldn't fail?
There was a problem hiding this comment.
Yes, there is a default timeout in VertxTestContext.
| vertx.setPeriodic(refreshPeriod, ignored -> fetchStoredDataResult(clock.millis(), MetricName.update)); | ||
| } | ||
|
|
||
| initializePromise.tryComplete(); |
There was a problem hiding this comment.
I'm still favouring the solution where the promise is completed with the first fetch result.
Failing to fetch stored impressions/requests is a critical sign that the new instance shouldn't startup.
And it should also open a port until the initial data is loaded.
|
I took a look on my smartphone with the Github App 😄 The only thing is the refresh service initialize promise. I'm convinced that it should resolve the promise with the initial fetch result |
|
Looks good 🥳 Thanks for polishing this up and make it ready to go. |
This PR is based on the work contributed by @muuki88 in PR #2733. We deeply appreciate @muuki88’s initial efforts, which greatly helped in shaping this final implementation. 🙌💪❤️