Add support for CPM override in Rubicon bidder #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGarbar
reviewed
May 25, 2020
| @@ -773,9 +787,45 @@ private Bid updateBid(Bid bid, BidResponse bidResponse) { | |||
| // copy bidResponse.bidid to openrtb_response.seatbid.bid.id | |||
| bid.setId(bidResponse.getBidid()); | |||
| } | |||
|
|
|||
| final Float cpmOverride = ObjectUtils.defaultIfNull(cpmOverrideFromImp(imp), cmpOverrideFromRequest); | |||
| if (cpmOverride != null) { | |||
There was a problem hiding this comment.
In Go they set price if it is more than zero, but probably it is bc they don't have nill.
But probably it is better to check, bc in this case, cpmOvveride can override normal price. (corner case)
There was a problem hiding this comment.
ok, added comment Unconditionally set price if coming from CPM override.
DGarbar
previously approved these changes
May 25, 2020
added 2 commits
July 30, 2020 16:20
# Conflicts: # docs/pbs-java-and-go-features-review.md # src/main/java/org/prebid/server/auction/ExchangeService.java # src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java # src/test/java/org/prebid/server/bidder/rubicon/RubiconBidderTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements prebid/prebid-server#1289