-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename synacormedia adapter to imds to reflect ownership change #2508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ails for "imds" and "synacormedia" adapters.
…ing the Go code. The documentaiton on prebid.org is not even remotely up-to-date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a bit more research and apparently in YAML quotes are sort of optional and only really needed when we want to escape quotes or other characters. Sorry 😅
LGTM
Not a problem. Happy to quote them anyhow to be safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…id#2508) Co-authored-by: Timothy M. Ace <tace@imds.tv>
This rename synacormedia adapter to imds to reflect ownership change, while leaving the synacormedia adapter in place referencing the imds adapter code to allow existing implementations to continue to function under the old name.
See also:
prebid/Prebid.js#9381
prebid/prebid.github.io#4237