Rename synacormedia adapter to imds to reflect ownership change #4237
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
@ecammit - renames are tricky, and you've done a very solid job here, leaving an alias in place. Thanks.
However, a side effect of changing synacormedia.md to have an aliasCode of imds is that the download page will no longer work for publishers that want to download an older version of PBJS -- the download page is always current, and but there won't be an 'imds' adapter in older versions of PBJS so those downloads will fail.
Options:
- leave off the aliasCode and add a 'pbjs_version_notes' metadata field that explains "download as imds in 7.X+"
- leave off the aliasCode and leave a 'stub' bid adapter in PBJS for synacormedia that just includes the entirety of imds. (I believe there's precedence for this -- the stub would get removed in 8.0)
|
There's already a stub adapter in the attached code pull requests, so I think I'll just remove the aliasCode. |
|
@ecammit - actually, the code PR sets synacormedia as an alias. This isn't going to work for new versions. I suggest adding the following to the header |
I assumed you meant a literal 7.X. If you don't, let me know and I can try to update it last minute to whatever the latest 7.x version is. One of the code branches was recently reviewed and is blocked, so I don't know what version this will sneak into at the moment. |
|
thanks - you're right that the 'X' should be resolved once we know what actual version it's in |
|
Looks like this is going to end up being in prebid 8. I'm going to gamble and say it'll make 8.0.0 and update this commit with that. |
…id#4237) * Change bid adapter for synacormedia to imds. Update adapter featureset. * Change synacormedia.md bidder doc to not reference aliasCode=imds * Added pbjs_version_notes to synacormedia docs to use imds after 7.x * Update synacormedia note with version 8.0 based upon anticipated release. --------- Co-authored-by: Timothy M. Ace <tace@imds.tv>
This renames the
synacormediaadapter toimdswhile allowing existing implementations to continue usingsynacormedia. This also updates the features in the documentation to reflect what's already supported in the current master.🏷 Type of documentation
📋 Checklist
prebid/prebid-server#2508
prebid/Prebid.js#9381