New Adapter: AdTonos

[rkaw92]

Hi! Meet AdTonos, an audio ad exchange and Prebid member 👋

Docs: prebid/prebid.github.io#5543

[github-actions]

Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeAudio, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

[rkaw92]

(Leaving this here because AdTonos is an audio ad exchange - we incidentally do audio-as-video for publishers which absolutely cannot play an audio ad due to technical constraints, but really we just want to return VASTs with sound only.)

[gargcreation1992]

@rkaw92 what bot is suggesting is to use Mtype field in the response to decide returned mediaType for an impression instead of relying on impID. For example,

func getBidType(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
	// determinate media type by bid response field mtype
	switch bid.MType {
	case openrtb2.MarkupBanner:
		return openrtb_ext.BidTypeBanner, nil
	case openrtb2.MarkupVideo:
		return openrtb_ext.BidTypeVideo, nil
	case openrtb2.MarkupAudio:
		return openrtb_ext.BidTypeAudio, nil
	case openrtb2.MarkupNative:
		return openrtb_ext.BidTypeNative, nil
	}

	return "", &errortypes.BadInput{
		Message: fmt.Sprintf("Could not define media type for impression: %s", bid.ImpID),
	}
}

[rkaw92]

Okay, makes sense. We don't have a way of always returning mtype currently, but I can add logic that will optionally use it when present, and fall back to the current heuristic if not. In the future, when mtype coverage increases, the code will have anticipated it.

[rkaw92]

I've added handling for when mtype is explicitly indicated and left the guesstimation in place as a fallback, does that look better?

[github-actions]

Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

[rkaw92]

the media type defaults to openrtb_ext.BidTypeVideo, nil.

I think the review bot may be wrong here - we default to audio, not video.

[gargcreation1992]

refer - https://github.com/prebid/prebid-server/pull/3853/files#r1721516798

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, c3cca60

adtonos

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adtonos/adtonos.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adtonos/adtonos.go:33:	MakeRequests		76.5%
github.com/prebid/prebid-server/v2/adapters/adtonos/adtonos.go:72:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adtonos/adtonos.go:77:	MakeBids		84.2%
github.com/prebid/prebid-server/v2/adapters/adtonos/adtonos.go:111:	getMediaTypeForImp	87.5%
total:									(statements)		84.3%

[gargcreation1992]

Sent email for verification.

[rkaw92]

Thank you, I believe a response has been sent back accordingly.

[gargcreation1992]

email verified. thanks!

[gargcreation1992]

user sync works.

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 1147599

adtonos

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adtonos/adtonos.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adtonos/adtonos.go:33:	MakeRequests		76.5%
github.com/prebid/prebid-server/v2/adapters/adtonos/adtonos.go:72:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adtonos/adtonos.go:77:	MakeBids		84.2%
github.com/prebid/prebid-server/v2/adapters/adtonos/adtonos.go:111:	getMediaTypeForBid	71.4%
total:									(statements)		80.7%

[rkaw92]

Hi, any more blockers here? I believe I've addressed all the suggestions.

Sorry, must have had an old version of the page loaded. Thanks!