GDPR-friendly /cookie_sync #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…robably still lots of bugs
… gdpr-fetch-vendorlists
dbemiller
added
needs docs
dbemiller
added
the
has docs
dbemiller
changed the title
hhhjort
reviewed
May 17, 2018
endpoints/cookie_sync.go
Outdated
| co.Status = http.StatusBadRequest | ||
| co.Errors = append(co.Errors, errors.New("Failed to check request.bidders in request body. Was your JSON well-formed?")) | ||
| http.Error(w, "Failed to check request.bidders in request body. Was your JSON well-formed?", http.StatusBadRequest) | ||
| } |
There was a problem hiding this comment.
Should there be a return here? If we are declaring an error condition in the response here, what use is further processing?
hhhjort
reviewed
May 17, 2018
| @@ -183,3 +183,10 @@ func assertBoolsEqual(t *testing.T, expected bool, actual bool) { | |||
| t.Errorf("Expected %t, got %t", expected, actual) | |||
| } | |||
| } | |||
|
|
|||
| func assertStringsEqual(t *testing.T, expected string, actual string) { | |||
There was a problem hiding this comment.
Is this function being used? This is the only change in the file, and it is a pure addition, so assertStringsEqual() couldn't have been there before.
There was a problem hiding this comment.
It's used in vendorlist-fetching_test.go. I was unsure whether I should put it in the file where it's used, or keep all the assert*Equal() functions together.
I can move it you think it's better the other way.
There was a problem hiding this comment.
its fine here, just noticed this was standing alone in the diff.
hhhjort
reviewed
May 17, 2018
usersync/usersyncers/syncer.go
Outdated
| @@ -26,6 +26,16 @@ func NewSyncerMap(cfg *config.Configuration) map[openrtb_ext.BidderName]usersync | |||
| } | |||
| } | |||
|
|
|||
| func ParseIdsGDPR(syncers map[openrtb_ext.BidderName]usersync.Usersyncer) map[openrtb_ext.BidderName]uint16 { | |||
| gdprAwareSyncers := make(map[openrtb_ext.BidderName]uint16, len(syncers)) | |||
There was a problem hiding this comment.
Not entirely happy with this name, as to me it implies the values should be syncers, not GDPR IDs. perhaps rename to gdprAwareSyncerIDs?
There was a problem hiding this comment.
Hah, actually referred to the first variable in the function rather than the function name itself, but this is good too. :)
hhhjort
requested changes
May 17, 2018
hhhjort
approved these changes
May 17, 2018
Merged
cirla
approved these changes
May 18, 2018
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
* Added a basic gdpr module for consent management. No tests yet, and probably still lots of bugs * Updated gopkg.lock. * Moved the URL creation into a function. * Made the URL-maker function a method arg, so it could be mocked out during testing. * Started some test helper code. * Added lots of tests. * Updated the /cookie_sync endpoint to recognize GDPR. * Patched up the gdpr module to respect configurable timeouts. * Added two new tests for untested code. * Making some cookie_sync code a bit more readable. * Added a test for a missing case. * Updated the /cookie_sync docs * Code review comments.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
* Added a basic gdpr module for consent management. No tests yet, and probably still lots of bugs * Updated gopkg.lock. * Moved the URL creation into a function. * Made the URL-maker function a method arg, so it could be mocked out during testing. * Started some test helper code. * Added lots of tests. * Updated the /cookie_sync endpoint to recognize GDPR. * Patched up the gdpr module to respect configurable timeouts. * Added two new tests for untested code. * Making some cookie_sync code a bit more readable. * Added a test for a missing case. * Updated the /cookie_sync docs * Code review comments.
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
* Added a basic gdpr module for consent management. No tests yet, and probably still lots of bugs * Updated gopkg.lock. * Moved the URL creation into a function. * Made the URL-maker function a method arg, so it could be mocked out during testing. * Started some test helper code. * Added lots of tests. * Updated the /cookie_sync endpoint to recognize GDPR. * Patched up the gdpr module to respect configurable timeouts. * Added two new tests for untested code. * Making some cookie_sync code a bit more readable. * Added a test for a missing case. * Updated the /cookie_sync docs * Code review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially implements #504, updating the
/cookie_syncendpoint. See the issue (or the docs in the PR) for the behavior.It does not yet forward the gdpr/consent info into the URLs so that it gets passed back into
/setuid. I believe those changes will mostly be in theUsersyncerinterface, so I'll save them for the next changeset.