Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liveintent user module docs added. #1493

Merged
merged 14 commits into from
Oct 15, 2019

Conversation

jankoulaga
Copy link
Contributor

@jankoulaga jankoulaga commented Sep 18, 2019

This reflects changes made in prebid/Prebid.js#4178

fixed typo, added to implementation section
@bretg
Copy link
Contributor

bretg commented Sep 20, 2019

Thanks @jankoulaga -

We need to update the Prebid Server bid adapter to pass your value through OpenRTB. What source field value would you like. e.g.

          {
                "source": "liveIntent",
                "uids": [{
                    "id": "11111111"
                }]
            }

Copy link
Member

@jdwieland8282 jdwieland8282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any mention of the segment Id/s being passed?

@jankoulaga
Copy link
Contributor Author

Thanks @jankoulaga -

We need to update the Prebid Server bid adapter to pass your value through OpenRTB. What source field value would you like. e.g.

          {
                "source": "liveIntent",
                "uids": [{
                    "id": "11111111"
                }]
            }

Hey @bretg, let's go with liveIntent as a source. Thanks.

@jankoulaga
Copy link
Contributor Author

I don't see any mention of the segment Id/s being passed?

Hey @jdwieland8282 the segments part in the response will be wrapped inside, depending whether any segment actually exist on our end.

At the time when we were writing these docs, we we're still investigating which segments will actually be added in the response, ad we thought it might be better to update these once we know more. WDYT?

| DigiTrust | IAB | bidRequest.userId.digitrustid | `{data: {id: "DTID", keyv: 4, privacy: {optout: false}, producer: "ABC", version: 2}` |
| ID5 ID | ID5 | bidRequest.userId.id5id | `"ID5-12345"` |
| ID5 ID | ID5 | bidRequest.userId.id5id | `"1111"` |
| IdentityLink | Trade Desk | bidRequest.userId.identityLink | `"1111"` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for IdentityLink, it is bidRequest.userId.idl_env https://github.com/prebid/Prebid.js/blob/master/modules/identityLinkIdSystem.js#L26
Let me know if i have mis-understood :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretg @idettman can you please confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idl_env is correct. Fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

Copy link
Member

@jdwieland8282 jdwieland8282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be some mention of the segment id that gets passed from the liveintent sub module.

@jankoulaga
Copy link
Contributor Author

@jdwieland8282 i've mentioned the segments and tried to cover it with an example in the userId object.

Copy link
Member

@jdwieland8282 jdwieland8282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating.

| ID5 ID | ID5 | bidRequest.userId.id5id | `"ID5-12345"` |
| ID5 ID | ID5 | bidRequest.userId.id5id | `"1111"` |
| IdentityLink | Trade Desk | bidRequest.userId.idl_env | `"1111"` |
| LiveIntent ID | Live Intent | bidRequest.userId.liveIntentId | `"1111"` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jankoulaga , @bretg
I see that in bidRequest object LiveIntent Id is passed as , bidUserId.lipb.lipbid
Refer: https://github.com/prebid/Prebid.js/pull/4178/files#diff-93e5cbcbb2aa2045b6e254010a1fc6b4R729
But in docs here, it is mentioned as bidRequest.userId.liveIntentId
Can you please check and let us know?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right @pm-harshad-mane. The path should be correct now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jankoulaga !!

@bretg
Copy link
Contributor

bretg commented Oct 15, 2019

released with 2.36

@bretg bretg merged commit 059b00b into prebid:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants