-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liveintent user module docs added. #1493
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ebb071b
Adding basic LiveIntentId info.
jankoulaga 498c9ac
Changed some wording.
jankoulaga ae5b886
Added the partner as a param
jankoulaga e2a703f
Added the partner config example.
jankoulaga 4b30e2b
Update userId.md
komplettsystem 715f53b
Merge remote-tracking branch 'origin/master' into liveintent-user-module
jankoulaga 4e5a652
misc updates
bretg bc2daec
tweaking openrtb values
bretg c689636
Mentioning segments in the response and userId object.
jankoulaga 679b148
Update userId.md
bretg 29806dd
Not mentioning ios
jankoulaga 048b794
Merge branch 'liveintent-user-module' of github.com:liveintent-berlin…
jankoulaga b3fe6b0
Merge branch 'master' into liveintent-user-module
bretg 7d780d0
Fixing the docs for lipb.lipbid
jankoulaga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jankoulaga , @bretg
I see that in bidRequest object LiveIntent Id is passed as ,
bidUserId.lipb.lipbid
Refer: https://github.com/prebid/Prebid.js/pull/4178/files#diff-93e5cbcbb2aa2045b6e254010a1fc6b4R729
But in docs here, it is mentioned as
bidRequest.userId.liveIntentId
Can you please check and let us know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right @pm-harshad-mane. The path should be correct now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jankoulaga !!