Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdMatic Adapter: New features (Pixad included) #5019

Merged
merged 16 commits into from
Mar 14, 2024

Conversation

fatihkaya84
Copy link
Contributor

@fatihkaya84 fatihkaya84 commented Dec 9, 2023

Pixad alias is included in the update.

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Dec 9, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 3822332
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/65f2d876e6af970008969ee8
😎 Deploy Preview https://deploy-preview-5019--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tcfeu_supported: true
usp_supported: true
coppa_supported: true
gpp_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gpp_supported: true
gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp

gpp_supported is deprecated and superseded by gpp_sids . Add the support section ids your adapter supports

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fatihkaya84 can you fix this? Then this is ready to merge 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp

hi @muuki88 sorry late reply :(
thank you very much for your interest and understanding

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. We are all working very async 😄

@muuki88 muuki88 removed the LGTM label Jan 11, 2024
dev-docs/bidders/admatic.md Show resolved Hide resolved
dev-docs/bidders/pixad.md Show resolved Hide resolved
@muuki88
Copy link
Contributor

muuki88 commented Feb 11, 2024

Thanks for the changes @fatihkaya84 There's still no gvl_id , which is required to claim tcf_supported: true . Without a GVL ID, prebid is not able to validate consent for your vendor, thus tcf is technically not supported.

@muuki88
Copy link
Contributor

muuki88 commented Mar 7, 2024

@fatihkaya84 are you habel to add the gvl_id ?

@fatihkaya84
Copy link
Contributor Author

@fatihkaya84 are you habel to add the gvl_id ?

Hi @muuki88 We are waiting for gvd id to be sent by IAB Europe. If there is a situation that affects prebid.js, what can I do to solve it?

@muuki88
Copy link
Contributor

muuki88 commented Mar 8, 2024

You need ID as it must also be configured in the adapter . Otherwise the gdprEnforcementModule will block all your calls.

@fatihkaya84
Copy link
Contributor Author

You need ID as it must also be configured in the adapter . Otherwise the gdprEnforcementModule will block all your calls.

Thanks for quick reply. Yes I know. We actually contacted IAB Europe and asked for a gvl id for this reason. We ran into a few bureaucratic issues. I remind they of the process over and over again every day to get it resolved quickly.
Please excuse me for keeping you busy.
Best.

@fatihkaya84
Copy link
Contributor Author

hi @muuki88 ,
I added gvl_id. Finally the process is completed.
Best.

@muuki88 muuki88 merged commit 61bd153 into prebid:master Mar 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants