Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdMatic Adapter: New features (Pixad included) #5019

Merged
merged 16 commits into from
Mar 14, 2024
Merged

AdMatic Adapter: New features (Pixad included) #5019

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a7de8ee
added simple params
fatihkaya84 Oct 26, 2023
84b3617
Merge branch 'prebid:master' into master
fatihkaya84 Oct 31, 2023
6f79a91
update
fatihkaya84 Oct 31, 2023
6630a61
Update admatic.md
fatihkaya84 Oct 31, 2023
506c427
update
fatihkaya84 Oct 31, 2023
20e9585
update
fatihkaya84 Oct 31, 2023
04c394c
Pixad Bid Adapter: added simple params
fatihkaya84 Oct 31, 2023
77ba71d
Merge branch 'prebid:master' into master
fatihkaya84 Dec 8, 2023
c227ef8
AdMatic Adapter: Feature update
fatihkaya84 Dec 9, 2023
1c948f6
Merge branch 'prebid:master' into master
fatihkaya84 Jan 3, 2024
e5c7c8c
Merge branch 'prebid:master' into master
fatihkaya84 Jan 11, 2024
6bb43de
Update admatic.md
fatihkaya84 Jan 11, 2024
4ea5fbb
Update pixad.md
fatihkaya84 Jan 11, 2024
93a3393
Merge branch 'prebid:master' into master
fatihkaya84 Mar 14, 2024
d94495e
gvl_id add
fatihkaya84 Mar 14, 2024
3822332
Update pixad.md
fatihkaya84 Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions dev-docs/bidders/admatic.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ pbjs: true
pbs: false
biddercode: admatic
media_types: banner,video,native
tcfeu_supported: false
usp_supported: false
coppa_supported: false
schain_supported: false
tcfeu_supported: true
muuki88 marked this conversation as resolved.
Show resolved Hide resolved
usp_supported: true
coppa_supported: true
gpp_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gpp_supported: true
gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp

gpp_supported is deprecated and superseded by gpp_sids . Add the support section ids your adapter supports

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fatihkaya84 can you fix this? Then this is ready to merge 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp

hi @muuki88 sorry late reply :(
thank you very much for your interest and understanding

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. We are all working very async 😄

schain_supported: true
dchain_supported: false
userIds: criteo, id5Id, sharedId, unifiedId
safeframes_ok: true
Expand Down
9 changes: 5 additions & 4 deletions dev-docs/bidders/pixad.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ pbjs: true
pbs: false
biddercode: pixad
media_types: banner,video,native
tcfeu_supported: false
usp_supported: false
coppa_supported: false
schain_supported: false
tcfeu_supported: true
muuki88 marked this conversation as resolved.
Show resolved Hide resolved
usp_supported: true
coppa_supported: true
gpp_supported: true
schain_supported: true
dchain_supported: false
userIds: criteo, id5Id, sharedId, unifiedId
safeframes_ok: true
Expand Down