Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[will not merge] Backport linear and non-linear examples to deal.II 9.1 #32

Closed
wants to merge 2 commits into from

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Jul 13, 2020

We recently updated added a non-linear example (see #24) and updated the minimum requirements to deal.II 9.2.0. This was good, as we always try to support the latest version of every solver.

However:

  • there are many recent systems where getting 9.1 is much easier than 9.2 (see Ubuntu 20.04, which has binaries for 9.1, but currently can only get 9.2 building from source)
  • the adapter seems easy to port to 9.1.

This is intended as a separate branch that we can give to users that quickly want to test the adapter/a tutorial, without having to upgrade deal.II. The Pull Request is here to easily see the diff.

@MakisH MakisH added the wontfix This will not be worked on label Jul 13, 2020
@davidscn
Copy link
Member

Everything correct here! The only left TODO is to apply the clang-format as provided in the repo here, which is the deal.II standard. At least for consistency, it would be nice. I could do it as well, if you don't have the configuration.

@MakisH
Copy link
Member Author

MakisH commented Jul 13, 2020

The only left TODO is to apply the clang-format as provided in the repo here, which is the deal.II standard.

Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants