-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deal.II cylinderFlap tutorial with fsi3 #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I was able to run (the first 100 timesteps of) the case and the results look meaningful. Installing SWAK worked out of the box for me.
Minor things:
- Please format your preCICE config with https://github.com/precice/precice/tree/develop/tools/formatting
- Could you please add a
plotDisplacement
(gnuplot) script?
@MakisH Could you please comment on the incompatibility with newer .org versions? How do we treat this for other cases?
This refers to this issue: #40 I fixed that in #78, essentially by adding a commented-out version for OpenFOAM 6 or newer in We already have this patch here, so I am not sure what else we should be looking for, @davidscn. |
I guess there is currently an incompatibility with newer
but in this case, we really care about convergence and the total number of iterations. The settings are related to the OF paper as well. In case anyone really wants to run this cases with the |
Replaces #105.
Resolves #94 and (at least partially) #77. This PR only updates the real 2D case of deal.II and not our pseudo 2D case. Potential tests will fail since this tutorial requires groovyBC.
There is one potential incompatibiliy with newer .org versions due to the residual setting in Fluid/system/fvSolution.