Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylinderFlap OpenFOAM: Remove residualControl, version-specific #78

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented May 22, 2020

Instead, offer commented-out ways to get the residualControl in the various OpenFOAM versions, with the current values.

This may affect convergence, but the purpose of the tutorial is to demonstrate how to configure preCICE and the adapters.

This fixes #40.

Instead, offer commented-out ways to get the residualControl
in the various OpenFOAM versions, with the current values.

This may affect convergence, but the purpose of the tutorial is to demonstrate
how to configure preCICE and the adapters.

This fixes #40.
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we we also make https://github.com/precice/tutorials/blob/cylinderFlap-of-version/FSI/cylinderFlap/OpenFOAM-FEniCS/Fluid/system/fvSolution consistent to the other files? I.e. providing the comments like //OpenFOAM 6 (.org) or newer that are introduced in this PR (writing this explicitly as a comment into the file is very helpful!) and using comments of the style /* ... */. I think it is mainly a question of style, but I would prefer having a consistent format everywhere.

I think

also need an update.

@MakisH MakisH changed the base branch from master to develop June 26, 2020 13:24
@MakisH
Copy link
Member Author

MakisH commented Jun 29, 2020

@BenjaminRueth Good point, I found and updated more cases, including the 3D_Tube. Feel free to check again. I have not checked the results of the cases, let's let Travis deal with that.

In the diff view, please set to "ignore whitespace", as I fixed a few formatting bits in these files as well. @Eder-K: This will probably slightly change the reference results.

Note that the .gitignore file of the FEniCS cases ignores the Fluid/ directory and then un-ignores the important things, which confused my editor and did not see it in the beginning. (#87)

@MakisH MakisH requested a review from BenjaminRodenberg June 29, 2020 12:06
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I hope you don't expect me to run anything. If yes: Then just rerequest a review and I will try to do it soonish.

@MakisH MakisH merged commit 9ef7cd9 into develop Jul 22, 2020
@MakisH MakisH deleted the cylinderFlap-of-version branch July 22, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some FSI tutorials are not working with OpenFOAM6
2 participants