feat: parse console scripts #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
reviewed
Dec 4, 2024
| @@ -204,6 +206,19 @@ impl PythonBuildBackend { | |||
| NoArchType::none() | |||
| }; | |||
|
|
|||
| // Determine the entry points from the pyproject.toml | |||
| // which would be passed into recipe | |||
| let python = if self.manifest.document.is_pyproject_toml() { | |||
There was a problem hiding this comment.
Hmm, I wonder if we should just re-parse the file as pyproject.toml?
There was a problem hiding this comment.
what do you mean? I thought that entry points are necessary only in case of pyproject.toml, so I'm explicitly avoiding the case when it is pixi.toml
There was a problem hiding this comment.
Yeah for sure, but we could parse the pyproject toml with pyproject-toml instead of through pixi. But doesn't really matter either!
There was a problem hiding this comment.
ah got it now! you meant with the pyproject-toml library
wolfv
approved these changes
Dec 4, 2024
Hofer-Julian
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
One tiny suggestion. Apart from that it looks great @nichmor!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fix/feature is necessary for windows pipeline failure : prefix-dev/pixi#2638
I've added some unit tests for parsing console scripts. Integration test itself will be this PR: prefix-dev/pixi#2638
Before merging this need to land:
prefix-dev/pixi#2643