Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example using rich and pixi-build-python and remove flask #2638

Merged
merged 12 commits into from
Dec 5, 2024

Conversation

Hofer-Julian
Copy link
Contributor

The other examples where not actually building a Python package with pixi-build-python

The other examples where not actually building a Python package with `pixi-build-python`
@Hofer-Julian Hofer-Julian requested a review from tdejager December 3, 2024 15:29
@baszalmstra
Copy link
Contributor

Wouldnt it make more sense to adapt the flask-hello-world-pyproject example as that also contains much more documentation regarding pixi-build?

@Hofer-Julian
Copy link
Contributor Author

Wouldnt it make more sense to adapt the flask-hello-world-pyproject example as that also contains much more documentation regarding pixi-build?

Yeah, probably.

Let me have a look!

@tdejager
Copy link
Contributor

tdejager commented Dec 3, 2024

@baszalmstra I think having both would be good, because the flask example is more or less building kind of a script workspace in a way or what uv calls an application: https://docs.astral.sh/uv/concepts/projects/init/#applications. Flask assumes to have app from the cwd by default, and this would be more like building an actual package. It would be good to adapt the flask example so that it works again, because it does not really seem to be working when we tested it.

@Hofer-Julian Hofer-Julian changed the title feat: add example using rich and pixi-build-python feat: add example using rich and pixi-build-python and remove flask Dec 3, 2024
@Hofer-Julian
Copy link
Contributor Author

As discussed with @baszalmstra and @tdejager, I removed the broken flask examples

@nichmor
Copy link
Contributor

nichmor commented Dec 4, 2024

looks cleaner and easier to understand. I've also tested pixi build and pixi install and works as expected. Let's fix CI and I think we can merge it

@nichmor
Copy link
Contributor

nichmor commented Dec 4, 2024

blocked on windows by missing entry points https://github.com/prefix-dev/rattler-build/blob/cff5ca53751d348a469bfbf9577e970d6797bdc5/docs/tutorials/python.md?plain=1#L101-L105.

tdejager and others added 5 commits December 4, 2024 16:57
## Description

This adds proper unit testing, for PyPI installations and adds a test
harness to test these things. This is a much more efficient and smaller
way of testing the functionality, specifically the need to
install/re-install then doing full integration tests.

## Checklist

- [x] Tests for direct url archives
- [x] Test for vcs installs.
- [x] See if we need to remove integration tests, because some of it is
tested here.

---------

Co-authored-by: Bas Zalmstra <bas@prefix.dev>
- move test data to common directory
- move helper functions to fixtures
@Hofer-Julian Hofer-Julian merged commit 7471787 into prefix-dev:main Dec 5, 2024
23 checks passed
@Hofer-Julian Hofer-Julian deleted the feat/rich-example branch December 5, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants