Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve tool.pixi.project detection logic #1127

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

olivier-lacroix
Copy link
Contributor

@olivier-lacroix olivier-lacroix commented Apr 6, 2024

@tdejager , as discussed, an improved detection of pixi project table in pyproject.toml , encapsulating all non-pixi pyproject.toml logic used during init into a struct.

plus minor cleanup (e.g. typo)

@olivier-lacroix olivier-lacroix marked this pull request as draft April 6, 2024 22:39
@olivier-lacroix olivier-lacroix changed the title chore: some cleanups feat: Improve tool.pixi.project detection logic Apr 7, 2024
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it's not ready for review. I did it anyways and it looks good to me 😄

@olivier-lacroix olivier-lacroix marked this pull request as ready for review April 8, 2024 09:53
@tdejager
Copy link
Contributor

tdejager commented Apr 8, 2024

Same here, going to merge!

@tdejager tdejager merged commit 11e2cf1 into prefix-dev:main Apr 8, 2024
24 checks passed
@olivier-lacroix olivier-lacroix deleted the cleanups branch April 20, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants