Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add request coalescing for isolated tools #2589

Merged
merged 14 commits into from
Dec 3, 2024

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented Nov 28, 2024

Overview

During installation of isolated tools, we request it for all platforms concurrently. This means that , in case of 4 platforms, we will try to install it 4 times.

This PR introduce a request coalescing system, that will allow only one resolution and instalation process to happen.

Some implementation details:

Copy link
Contributor

@tdejager tdejager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you create a test that might test for parallel installs using tokio spawn and the multihreaded executor?

crates/pixi_build_frontend/src/tool/cache.rs Outdated Show resolved Hide resolved
crates/pixi_build_frontend/src/tool/cache.rs Outdated Show resolved Hide resolved
crates/pixi_build_frontend/src/tool/mod.rs Outdated Show resolved Hide resolved
@baszalmstra baszalmstra added the area:build Related to pixi build label Dec 2, 2024
@nichmor nichmor enabled auto-merge (squash) December 2, 2024 13:49
@nichmor
Copy link
Contributor Author

nichmor commented Dec 2, 2024

failure of CI is expected because of this:
#2601 (comment)

@nichmor nichmor disabled auto-merge December 3, 2024 10:55
@baszalmstra baszalmstra merged commit 2e8483d into prefix-dev:main Dec 3, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:build Related to pixi build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants