-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add request coalescing for isolated tools #2589
Merged
baszalmstra
merged 14 commits into
prefix-dev:main
from
nichmor:fix/install-tool-req-coalescing
Dec 3, 2024
Merged
feat: add request coalescing for isolated tools #2589
baszalmstra
merged 14 commits into
prefix-dev:main
from
nichmor:fix/install-tool-req-coalescing
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdejager
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you create a test that might test for parallel installs using tokio spawn and the multihreaded executor?
tdejager
approved these changes
Dec 2, 2024
baszalmstra
reviewed
Dec 2, 2024
baszalmstra
reviewed
Dec 2, 2024
baszalmstra
approved these changes
Dec 2, 2024
failure of CI is expected because of this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
During installation of isolated tools, we request it for all platforms concurrently. This means that , in case of 4 platforms, we will try to install it 4 times.
This PR introduce a request coalescing system, that will
allow
only one resolution and instalation process to happen.Some implementation details: