-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [build-system.build-backend] #2601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # crates/pixi_build_frontend/src/protocol_builder.rs # crates/pixi_build_frontend/src/protocols/builders/conda_build/mod.rs # crates/pixi_build_frontend/src/protocols/builders/rattler_build.rs # crates/pixi_build_frontend/src/tool/spec.rs
Channels is also optional and defaults to the project channels, right? |
Yes but not in this pr yet |
@baszalmstra you might have to change it here as well: https://github.com/prefix-dev/pixi/blob/main/tests/integration_python/pixi_build/test-data/rattler-build-backend/pixi/pixi.toml |
wolfv
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We decided to refactor the way we format the
[build-system]
section because it was confusing, inconsistently formatted with the rest of the file and contained some duplication.Previously the
[build-system]
section would look like:We decided to reformat this as:
The
build-backend
describes both the package and the executable to invoke in the package. Additional dependencies can be added through theadditional-dependencies
field. I also added loads of errors for corner cases.