Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [build-system.build-backend] #2601

Merged
merged 15 commits into from
Dec 2, 2024

Conversation

baszalmstra
Copy link
Contributor

Description

We decided to refactor the way we format the [build-system] section because it was confusing, inconsistently formatted with the rest of the file and contained some duplication.

Previously the [build-system] section would look like:

[build-system]
dependencies = ["python-build-backend > 12"]
build-backend = "python-build-backend"
channels = ["conda-forge"]

We decided to reformat this as:

[build-system]
build-backend = { name = "python-build-backend", version = ">12"  }
channels = ["conda-forge"]

# optional
additional-dependencies = { git = "*" }

The build-backend describes both the package and the executable to invoke in the package. Additional dependencies can be added through the additional-dependencies field. I also added loads of errors for corner cases.

baszalmstra and others added 8 commits November 29, 2024 16:53
# Conflicts:
#	crates/pixi_build_frontend/src/protocol_builder.rs
#	crates/pixi_build_frontend/src/protocols/builders/conda_build/mod.rs
#	crates/pixi_build_frontend/src/protocols/builders/rattler_build.rs
#	crates/pixi_build_frontend/src/tool/spec.rs
@wolfv
Copy link
Member

wolfv commented Nov 29, 2024

Channels is also optional and defaults to the project channels, right?

@baszalmstra
Copy link
Contributor Author

Yes but not in this pr yet

@wolfv
Copy link
Member

wolfv commented Nov 30, 2024

@baszalmstra you might have to change it here as well: https://github.com/prefix-dev/pixi/blob/main/tests/integration_python/pixi_build/test-data/rattler-build-backend/pixi/pixi.toml

@baszalmstra baszalmstra added the area:build Related to pixi build label Dec 2, 2024
@wolfv wolfv merged commit 5ce9827 into prefix-dev:main Dec 2, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:build Related to pixi build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants