Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Iterate, Fix Optimum Nvidia Benchmark and add Readme #138

Merged
merged 10 commits into from
Jan 31, 2024

Conversation

Anindyadeep
Copy link
Member

@Anindyadeep Anindyadeep commented Jan 23, 2024

Checks:

  • Checksetup.sh and bench.sh have Python files configured for both Mac and Linux and installation working.
  • Check if int32 < int16 patterns follow.
  • Check the log file name and where it is kept.
  • Check if all precisions can be covered or not and if not put an issue.
  • Check if all devices can be covered or not otherwise put an issue or find an issue (it's just memory issue and too slow, mentioned in Readme).
  • Check the Benchmark README.

@Anindyadeep Anindyadeep self-assigned this Jan 23, 2024
@Anindyadeep Anindyadeep marked this pull request as draft January 24, 2024 10:41
@Anindyadeep Anindyadeep changed the title Optimum Nvidia Readme. Re-Iterate, Fix Optimum Nvidia Benchmark and add Readme Jan 30, 2024
@Anindyadeep Anindyadeep marked this pull request as ready for review January 30, 2024 12:07
@Anindyadeep Anindyadeep requested a review from nsosio January 30, 2024 12:08
Copy link
Collaborator

@nsosio nsosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsosio nsosio merged commit a2909eb into premAI-io:main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants