.NET C# no way to enable different .NET sdk's on .netcore projects! #2289

lolrobbe2 · 2024-10-07T17:41:34Z

What does this PR do?

Add support for setting .NET sdk using dotnetsdk option. (only on new format projects otherwise just use the defautl)

Web
Razor
Worker
Blazor (BlazorWebAssembly)
WindowsDesktop
default (Microsoft.NET.Sdk)

How does this PR change Premake's behavior?

adds a new option called dotnetsdk

Anything else we should know?

Add any other context about your changes here.

Did you check all the boxes?

Focus on a single fix or feature; remove any unrelated formatting or code changes
Add unit tests showing fix or feature works; all tests pass
Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
Follow our coding conventions
Minimize the number of commits
Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

for some reason it took the commits from my previous pr (add C# documentation file to) i didn't change these files tho!

closes #2288

(functional result stays the same)

modules/vstudio/vs2005_dotnetbase.lua

website/docs/dotnetsdk.md

src/_premake_init.lua

modules/vstudio/vs2005_dotnetbase.lua

Jarod42 · 2024-10-09T14:14:42Z

modules/vstudio/tests/cs2005/test_dotnetsdk.lua

+<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
+		]]
+	end
+	function suite.testMSTest()


global.json part is not tested

how would i go about that?

Issue is probably that global.json doesn't follow other file generation and so dotnetbase.netcore.dotnetsdk would be misplaced...

would you happen to know where i can find another example of this file generating?

I though about premake.generate, something like:

local content = p.capture(function() generate_global_json_content(prj) end) if content ~= nil and #content > 0 then p.generate(prj, "global.json", function() p.outln(content) end) end

That way, generate_global_json_content can be tested.
User is notified of the creation of the file.

i got premake.generate to work except the test is not working probably somthing stupid that i am missing!

i got this far but it seems the content is not getting captured properly

…in test case but is written in normal ussage

…ause the file is created fine when using in non test environment! also tried changing dir to _TESTS_DIR to no avail.

lolrobbe2 · 2024-10-09T20:32:37Z

Could it be that tests are blocked from creating files? wich would explain why the file is not found!

…iate place as file writing is working

Jarod42 · 2024-10-10T12:20:29Z

Could it be that tests are blocked from creating files? what would explain why the file is not found!

There is indeed test_runner.lua which installs custom hooks to avoid file creation.
Test should not use file, but check what they output to them.

…o much!

Jarod42 · 2024-10-10T17:24:08Z

modules/vstudio/vs2005_dotnetbase.lua

 		-- do not remove the file generation for global.json otherwise MSTest will not work!!!
 		local globalpath = path.join(cfg.workspace.location, "global.json")
 		if cfg.dotnetsdk == "MSTest" and not os.isfile(globalpath) then
-			io.writefile(globalpath, '{"msbuild-sdks": {"MSTest.Sdk": "3.6.1"}}')
+			local content = p.capture(function() generate_global_json_content(prj) end)
+			if content ~= nil and #content > 0 then
+				p.generate(cfg.workspace, path.join(cfg.workspace.location,"global.json"), function() p.outln(content) end)
+			end
 		end
 	end


I meant:

Suggested change

-- do not remove the file generation for global.json otherwise MSTest will not work!!!

local globalpath = path.join(cfg.workspace.location, "global.json")

if cfg.dotnetsdk == "MSTest" and not os.isfile(globalpath) then

io.writefile(globalpath, '{"msbuild-sdks": {"MSTest.Sdk": "3.6.1"}}')

local content = p.capture(function() generate_global_json_content(prj) end)

if content ~= nil and #content > 0 then

p.generate(cfg.workspace, path.join(cfg.workspace.location,"global.json"), function() p.outln(content) end)

end

end

end

function dotnetbase.output_global_json(prj) -- unsure how you handle project with different config

if cfg.dotnetsdk == "MSTest" then

_p('{"msbuild-sdks": {"MSTest.Sdk": "3.6.1"}}')

end

end

function dotnetbase.generate_global_json(prj)

local content = p.capture(function() dotnetbase.output_global_json(prj) end)

if content ~= nil and #content > 0 then

p.generate(prj, path.join(prj.workspace.location,"global.json"), function() p.outln(content) end)

end

end

In vs2005.generateProject(prj)
Add dotnetbase.generate_global_json(prj) in iscsharp and in isfsharp branch.

In test, just check output of dotnetbase.output_global_json

ill give it try!

getting somewhere but now other test is broken

fixed it it is now working!! btw thanks for the help!!!

lolrobbe2 · 2024-10-10T19:15:14Z

the error in mingw is because it cannot connect to nuget services!

lolrobbe2 · 2024-10-10T20:19:00Z

question: when is beta 3 planned to be released because i would like to have a look a the platforms bug and see if i can fix it potentially?

Jarod42 · 2024-10-11T13:15:06Z

modules/vstudio/vs2005_dotnetbase.lua

 	function dotnetbase.allowUnsafeBlocks(cfg)
 		if cfg.clr == "Unsafe" then
 			_p(2,'<AllowUnsafeBlocks>true</AllowUnsafeBlocks>')
 		end
 	end
+
+	function dotnetbase.output_global_json(prj) -- unsure how you handle project with different config


The comment was for you ;-)
Does it make sense that user have something like

filter "configuration:Release" dotnetsdk "Web" filter "configuration:Test" dotnetsdk "MSTest"

How do you handle it?
As it seems global.json would be ignored with other dotnetsdk, checking that at least one cfg has this flag might be the solution

no not really as they are seperate frameworks i see absolutly no reason ass it imports different namespaces etc and would break code!
global.json is also only needed to define the version of the MSTest sdk other sdk's do this automatically

Jarod42 · 2024-10-11T13:18:44Z

modules/vstudio/vs2005_dotnetbase.lua

+	function dotnetbase.generate_global_json(prj)
+				local content = p.capture(function() dotnetbase.output_global_json(prj) end)
+				if content ~= nil and #content > 0 then
+					p.generate(prj, path.join(prj.workspace.location,"global.json"), function() p.outln(content) end)


Suggested change

p.generate(prj, path.join(prj.workspace.location,"global.json"), function() p.outln(content) end)

p.generate(prj, path.join(prj.workspace.location, "global.json"), function() p.outln(content) end)

BTW, I removed your check to not overwrite existing file for simplicity in precedent suggestion.
Unsure of your expected behavior with existing file.
If you keep existing code, doc should be updated as existing file would be overwritten.

preferebly you would just append it to the global.json file or update it but have no idea on how to acomplish that with existing json api's

gonna have a look at json.decode and encode to make it so it just updates the version or generates it when missing!

…ng due to using p.generate twice!

Jarod42 · 2024-10-14T12:33:18Z

modules/vstudio/vs2005_dotnetbase.lua

+			globaljson = json.decode(io.readfile(path.join(prj.workspace.location, "global.json")))
+			if globaljson == nil then
+				globaljson = {}
+				globaljson["msbuild-sdks"] = {}
+				globaljson["msbuild-sdks"]["MSTest.Sdk"] = "3.6.1"
+			elseif globaljson["msbuild-sdks"] ~= nil then
+				globaljson["msbuild-sdks"]["MSTest.Sdk"] = "3.6.1"
+			else
+				globaljson["msbuild-sdks"] = {}
+				globaljson["msbuild-sdks"]["MSTest.Sdk"] = "3.6.1"
+			end


Suggested change

globaljson = json.decode(io.readfile(path.join(prj.workspace.location, "global.json")))

if globaljson == nil then

globaljson = {}

globaljson["msbuild-sdks"] = {}

globaljson["msbuild-sdks"]["MSTest.Sdk"] = "3.6.1"

elseif globaljson["msbuild-sdks"] ~= nil then

globaljson["msbuild-sdks"]["MSTest.Sdk"] = "3.6.1"

else

globaljson["msbuild-sdks"] = {}

globaljson["msbuild-sdks"]["MSTest.Sdk"] = "3.6.1"

end

globaljson = json.decode(io.readfile(path.join(prj.workspace.location, "global.json")))

globaljson = globaljson or {}

globaljson["msbuild-sdks"] = globaljson["msbuild-sdks"] or {}

globaljson["msbuild-sdks"]["MSTest.Sdk"] = "3.6.1"

robbe beernaert and others added 30 commits June 29, 2023 17:49

added C# documentationFile feature

34a8b7b

wrote unit tests for C# documentationFile

42128d0

removed null opt to not enable documentationFile

753b78e

add documentationFile documentation

c74f42f

add documentationFile documentation

3c168d9

resolve merge confflict with documentation

6a5bee2

added some extra info for custom dir

3c60b2c

implemented comments

aa6bac0

fixed title

faae641

fixed spelling + addd test

17a9b04

fixed spelling + addd test

ac1b8cb

Merge branch 'master' of https://github.com/lolrobbe2/premake-core

652ab29

improved grammar / capitalization

a228108

changed styling of the documentation

fe84d57

changed docs to fit api

e831595

added MSFT links to See Also

dbd70b5

fixed capitalization

19715dd

changed wording/ capitalization of documentation

ce31e60

removed the slashes!

40167fe

added documenationfile to the sidebar

9707d8f

Rename documentationFile.md to documentationfile.md

3533b2a

merged from master

36903cc

added support for newer <GenerateDocumentationFile> tag

f50609c

(functional result stays the same)

Merge branch 'master' of https://github.com/premake/premake-core

912aac2

changed tests

44165f5

changed default from documentationfile "" to documentationfile(true)

ef4ac4d

changed documentation to match!

3ec3b33

changed availability in docs for documentationfile.md

28374f7

Merge branch 'master' of https://github.com/premake/premake-core

1946ed0

added support to select .NET sdk in visual studio.

d0bd40f

Jarod42 reviewed Oct 9, 2024

View reviewed changes

modules/vstudio/vs2005_dotnetbase.lua Outdated Show resolved Hide resolved

modules/vstudio/vs2005_dotnetbase.lua Outdated Show resolved Hide resolved

website/docs/dotnetsdk.md Outdated Show resolved Hide resolved

src/_premake_init.lua Outdated Show resolved Hide resolved

Jarod42 reviewed Oct 9, 2024

View reviewed changes

modules/vstudio/vs2005_dotnetbase.lua Outdated Show resolved Hide resolved

implemented feedback from Jarod42

566a587

lolrobbe2 requested a review from Jarod42 October 9, 2024 13:21

Jarod42 reviewed Oct 9, 2024

View reviewed changes

lolrobbe2 requested a review from Jarod42 October 9, 2024 14:54

Beernaert Robbe added 2 commits October 9, 2024 18:11

added test but test is not fully correct because file is not written …

9fe2531

…in test case but is written in normal ussage

at this point when running tests file creation is blocked i think bec…

1a25b9f

…ause the file is created fine when using in non test environment! also tried changing dir to _TESTS_DIR to no avail.

removed the global.json test and put a warning comment in the appropr…

d30ae4c

…iate place as file writing is working

premake.generate is kinda working as intended but the test part not s…

31e5606

…o much!

Jarod42 reviewed Oct 10, 2024

View reviewed changes

fixed the testMSTestGlobalJSON (thanks jarod for the help!)

6a8abbc

lolrobbe2 requested a review from Jarod42 October 10, 2024 19:03

Beernaert Robbe added 2 commits October 10, 2024 21:04

fixed the indentation

b36e1a0

forgot to fix the indentation

8f11868

made global.json look a bit better for endusers.

0243b80

Jarod42 reviewed Oct 11, 2024

View reviewed changes

the desired flow for global.json is working but the test is not worki…

1338f3a

…ng due to using p.generate twice!

lolrobbe2 requested a review from Jarod42 October 14, 2024 10:28

Jarod42 reviewed Oct 14, 2024

View reviewed changes

Beernaert Robbe added 2 commits October 14, 2024 14:40

implemented feedback from jarod

e17721f

fixed thr broken global.json test

32cba9e

lolrobbe2 requested a review from Jarod42 October 14, 2024 20:40

Merge branch 'premake:master' into master

511df68

Jarod42 approved these changes Nov 4, 2024

View reviewed changes

Merge branch 'premake:master' into master

9dd9591

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

.NET C# no way to enable different .NET sdk's on .netcore projects! #2289

.NET C# no way to enable different .NET sdk's on .netcore projects! #2289

lolrobbe2 commented Oct 7, 2024 •

edited

Loading

Jarod42 Oct 9, 2024

lolrobbe2 Oct 9, 2024

Jarod42 Oct 9, 2024

lolrobbe2 Oct 9, 2024

Jarod42 Oct 10, 2024

lolrobbe2 Oct 10, 2024

lolrobbe2 Oct 10, 2024

lolrobbe2 commented Oct 9, 2024

Jarod42 commented Oct 10, 2024

Jarod42 Oct 10, 2024

lolrobbe2 Oct 10, 2024

lolrobbe2 Oct 10, 2024

lolrobbe2 Oct 10, 2024 •

edited

Loading

lolrobbe2 commented Oct 10, 2024

lolrobbe2 commented Oct 10, 2024 •

edited

Loading

Jarod42 Oct 11, 2024

lolrobbe2 Oct 12, 2024 •

edited

Loading

Jarod42 Oct 11, 2024

lolrobbe2 Oct 12, 2024

lolrobbe2 Oct 14, 2024

Jarod42 Oct 14, 2024

	p.generate(prj, path.join(prj.workspace.location,"global.json"), function() p.outln(content) end)
	p.generate(prj, path.join(prj.workspace.location, "global.json"), function() p.outln(content) end)

.NET C# no way to enable different .NET sdk's on .netcore projects! #2289

Are you sure you want to change the base?

.NET C# no way to enable different .NET sdk's on .netcore projects! #2289

Conversation

lolrobbe2 commented Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lolrobbe2 commented Oct 9, 2024

Jarod42 commented Oct 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lolrobbe2 Oct 10, 2024 • edited Loading

Choose a reason for hiding this comment

lolrobbe2 commented Oct 10, 2024

lolrobbe2 commented Oct 10, 2024 • edited Loading

Choose a reason for hiding this comment

lolrobbe2 Oct 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lolrobbe2 commented Oct 7, 2024 •

edited

Loading

lolrobbe2 Oct 10, 2024 •

edited

Loading

lolrobbe2 commented Oct 10, 2024 •

edited

Loading

lolrobbe2 Oct 12, 2024 •

edited

Loading