Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET C# no way to enable different .NET sdk's on .netcore projects! #2289
.NET C# no way to enable different .NET sdk's on .netcore projects! #2289
Changes from 41 commits
34a8b7b
42128d0
753b78e
c74f42f
3c168d9
6a5bee2
3c60b2c
aa6bac0
faae641
17a9b04
ac1b8cb
652ab29
a228108
fe84d57
e831595
dbd70b5
19715dd
ce31e60
40167fe
9707d8f
3533b2a
36903cc
f50609c
912aac2
44165f5
ef4ac4d
3ec3b33
28374f7
1946ed0
d0bd40f
29fe49f
8cf3ccc
63964d8
76b9709
b409321
67b90c3
e0a4f80
06ce5b6
bff0fa9
3698bec
566a587
9fe2531
1a25b9f
d30ae4c
31e5606
6a8abbc
b36e1a0
8f11868
0243b80
1338f3a
e17721f
32cba9e
511df68
9dd9591
1c81c86
83a9cae
8099d0f
c76940b
06ee29e
4b0eb5a
1cdac64
f46c5e6
cc6c8ae
ff88efc
77f5d08
e707056
facb727
9c7f6e4
6223a4b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global.json part is not tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how would i go about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue is probably that global.json doesn't follow other file generation and so
dotnetbase.netcore.dotnetsdk
would be misplaced...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you happen to know where i can find another example of this file generating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though about
premake.generate
, something like:That way,
generate_global_json_content
can be tested.User is notified of the creation of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i got premake.generate to work except the test is not working probably somthing stupid that i am missing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i got this far but it seems the content is not getting captured properly