Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher float #503

Merged
merged 5 commits into from
Feb 14, 2019
Merged

Publisher float #503

merged 5 commits into from
Feb 14, 2019

Conversation

dannylonglegs
Copy link
Contributor

Add variable for publisher and publisher city float and set variable to none.

@dannylonglegs dannylonglegs added enhancement New feature or request buckram This issue affects book theme components labels Feb 13, 2019
@dannylonglegs dannylonglegs added this to the buckram@1.4.0 milestone Feb 13, 2019
Copy link
Contributor

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #503 into dev will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #503      +/-   ##
==========================================
+ Coverage   30.22%   30.52%   +0.29%     
==========================================
  Files           4        4              
  Lines         407      403       -4     
==========================================
  Hits          123      123              
+ Misses        284      280       -4
Impacted Files Coverage Δ
inc/actions/namespace.php 6.54% <0%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b52b96...bae0083. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #503 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #503   +/-   ##
=======================================
  Coverage   30.52%   30.52%           
=======================================
  Files           4        4           
  Lines         403      403           
=======================================
  Hits          123      123           
  Misses        280      280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a339286...1728c62. Read the comment docs.

@greatislander
Copy link
Contributor

@dannylonglegs Can you also add a changelog entry to /packages/buckram/CHANGELOG.md? You can follow my example from #501.

@greatislander greatislander merged commit ec2782e into dev Feb 14, 2019
@greatislander greatislander deleted the publisher-float branch February 14, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buckram This issue affects book theme components enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants