Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher float #503

Merged
merged 5 commits into from
Feb 14, 2019
Merged

Publisher float #503

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c36698c
Add publisher and publisher city float variable and set it to none
dannylonglegs Feb 13, 2019
028ad52
Add missing text
dannylonglegs Feb 13, 2019
bae0083
Add missing
dannylonglegs Feb 13, 2019
da2d445
Update changelog
dannylonglegs Feb 13, 2019
1728c62
Merge branch 'dev' into publisher-float
Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/buckram/assets/styles/components/pages/_titles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ div.publisher-logo {

h4.publisher {
display: block;
float: bottom;
float: if-map-get($title-publisher-float, $type);
margin: if-map-get($title-publisher-margin-top, $type) if-map-get($title-publisher-margin-right, $type) if-map-get($title-publisher-margin-bottom, $type) if-map-get($title-publisher-margin-left, $type);
font-family: $title-publisher-font-family;
font-size: if-map-get($title-publisher-font-size, $type);
Expand All @@ -127,7 +127,7 @@ h4.publisher {
}

h5.publisher-city {
float: bottom;
float: if-map-get($title-publisher-city-float, $type);
margin-top: 0;
margin-left: if-map-get($title-publisher-city-margin-left, $type);
margin-right: if-map-get($title-publisher-city-margin-right, $type);
Expand Down
10 changes: 10 additions & 0 deletions packages/buckram/assets/styles/variables/_pages.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,11 @@ $title-publisher-margin-bottom: (epub: 0.5em, prince: 0.5em, web: 0.5em) !defaul
/// @since 1.2.0
$title-publisher-margin-left: (epub: 0, prince: 0, web: 0) !default;

/// Float for title page publisher text on elements `<h4>` with a class of `publisher`.
/// @type String | Map
/// @since 1.4.0
$title-publisher-float: (epub: none, prince: none, web: none) !default;

/// Font stack for title page publisher text on elements `<h4>` with a class of `publisher`.
/// @type String
$title-publisher-font-family: $font-3 !default;
Expand Down Expand Up @@ -454,6 +459,11 @@ $title-publisher-city-margin-right: $title-publisher-margin-right !default;
/// @since 1.2.0
$title-publisher-city-margin-left: $title-publisher-margin-left !default;

/// Float for title page publisher city text on elements `<h5>` with a class of `publisher-city`.
/// @type String | Map
/// @since 1.4.0
$title-publisher-city-float: (epub: none, prince: none, web: none) !default;

/// Font stack for title page publisher city text on elements `<h5>` with a class of `publisher-city`.
/// @type String
$title-publisher-city-font-family: $font-3 !default;
Expand Down