Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page number HTML #879

Closed
wants to merge 1 commit into from
Closed

Fix page number HTML #879

wants to merge 1 commit into from

Conversation

arzola
Copy link
Contributor

@arzola arzola commented Oct 26, 2021

This PR is part of pressbooks/pressbooks#2443

Those elements are not an H3 anymore, I think it's better to leave as a class only they actually nested inside other tag

Note: This should be merged with pressbooks/pressbooks#2457

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #879 (9903aed) into dev (33ec643) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #879   +/-   ##
=======================================
  Coverage   47.96%   47.96%           
=======================================
  Files           4        4           
  Lines         467      467           
=======================================
  Hits          224      224           
  Misses        243      243           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ec643...9903aed. Read the comment docs.

@arzola arzola marked this pull request as ready for review October 26, 2021 01:12
@SteelWagstaff SteelWagstaff changed the title Fixed page number HTML Fix page number HTML Oct 26, 2021
@SteelWagstaff SteelWagstaff self-requested a review October 26, 2021 14:36
Copy link
Member

@SteelWagstaff SteelWagstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Waiting until related PR in pressbooks/pressbooks is merged before merging this one.

@arzola
Copy link
Contributor Author

arzola commented Nov 5, 2021

Solved by #887

@arzola arzola closed this Nov 5, 2021
@SteelWagstaff SteelWagstaff deleted the fix-page-schema branch September 20, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants