fix: new semantic HTML selectors #887
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #887 +/- ##
=======================================
Coverage 47.96% 47.96%
=======================================
Files 4 4
Lines 467 467
=======================================
Hits 224 224
Misses 243 243
Continue to review full report at Codecov.
|
| @@ -219,13 +219,7 @@ | |||
| } | |||
|
|
|||
| @if $type == 'prince' { | |||
| h3.front-matter-number, | |||
There was a problem hiding this comment.
This is not needed anymore https://www.princexml.com/doc/pdf-bookmarks/#bookmark-levels because we are not using a title tag
| @@ -167,7 +167,7 @@ h1.front-matter-title { | |||
| } | |||
|
|
|||
| // PART TITLE COLOR | |||
| h3.part-number { | |||
| p.part-number { | |||
There was a problem hiding this comment.
Wouldn't it be better if we removed element selectors altogether and just targeted elements with the .part-number class?
There was a problem hiding this comment.
Yes, we discussed that on Friday I wasn't sure if the .part-number exists in other contexts but definitely I can look into that
|
@SteelWagstaff I sent the agreed changes in the morning and I used a new commit message using the conventional commits strategy |
SteelWagstaff
changed the title
| h1.back-matter-title + h2.chapter-subtitle, | ||
| .short-title + h2.chapter-subtitle { | ||
| h1.back-matter-title + .chapter-subtitle, | ||
| .short-title + p.chapter-subtitle { |
There was a problem hiding this comment.
remove h1 and p references here?
arzola
force-pushed
the
pb-2452-styling
branch
from
5a29d2e
to
2de84a1
Compare
There was a problem hiding this comment.
Differences between print PDF exports in old and new branches:
-
Missing blank pages before and after half title page when book has 'before title page' content in new branch
-
No space between contributors and press info on title page (left = new, right = old):
-
Subtitles in ToC are broken (left = new, right = old)
-
Footnote content in front matter missing in new exports:
| h1.back-matter-title + h2.chapter-author, | ||
| .short-title + h2.chapter-author { | ||
| h1.back-matter-title + .chapter-author, | ||
| .short-title + p.chapter-author { |
There was a problem hiding this comment.
remove h1 and p references here?
| margin-top: if-map-get($section-title-author-spacing, $type); | ||
| } | ||
|
|
||
| h2.chapter-subtitle + h2.chapter-author { | ||
| .chapter-subtitle + .chapter-author { | ||
| margin-top: if-map-get($section-subtitle-author-spacing, $type); | ||
| } | ||
|
|
||
| h1.back-matter-title:last-child { |
| @@ -114,25 +114,25 @@ | |||
| word-spacing: if-map-get($section-author-word-spacing, $type); | |||
| } | |||
|
|
|||
| h2.chapter-title + h2.chapter-subtitle, | |||
| .short-title + h2.chapter-subtitle { | |||
| h2.chapter-title + .chapter-subtitle, | |||
| @@ -177,7 +177,7 @@ blockquote.aphorism { | |||
| margin-bottom: 0; | |||
| } | |||
|
|
|||
| h3.chapter-number { | |||
| p.chapter-number { | |||
| @@ -78,25 +78,25 @@ | |||
| word-spacing: if-map-get($section-author-word-spacing, $type); | |||
| } | |||
|
|
|||
| h1.front-matter-title + h2.chapter-subtitle, | |||
| .short-title + h2.chapter-subtitle { | |||
| h1.front-matter-title + .chapter-subtitle, | |||
| margin-top: if-map-get($section-title-subtitle-spacing, $type); | ||
| } | ||
|
|
||
| h1.front-matter-title + h2.chapter-author, | ||
| .short-title + h2.chapter-author { | ||
| h1.front-matter-title + .chapter-author, |
There was a problem hiding this comment.
Differences between digital PDF
- Links including author names are not styled with the same link color as other links in the ToC:
- The introduction is not moved into its expected order -- should appear after the foreward. See https://guide.pressbooks.com/chapter/create-and-edit-front-matter/#chapter-179-section-5
This PR closes pressbooks/pressbooks#2452
How to test.
Export a book with different formats and you should see the same styling as the integrations/production networks.