Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify 2D menu constants #757

Closed
Rangi42 opened this issue Aug 3, 2020 · 2 comments
Closed

Identify 2D menu constants #757

Rangi42 opened this issue Aug 3, 2020 · 2 comments
Assignees
@mid-kid
Labels
renaming

Comments

@Rangi42
Copy link
Member

Rangi42 commented Aug 3, 2020

PR #756 identifies some 2D menu data, but the roles of the bitflag constants are not known yet.
@mid-kid
Copy link
Member

mid-kid commented Aug 3, 2020

w2DMenuFlags1 is mostly known and documented in both docs/menu.md and wram.asm, it just needs constants and for w2DMenuFlags2 to be documented. Also, the relationship of this vs _2DMenu is unknown.

@Rangi42 Rangi42 mentioned this issue Aug 22, 2020
Merged
@Rangi42
Copy link
Member Author

Rangi42 commented Oct 17, 2024

These were identified as part of pret/pokegold#120, which will be ported to pokecrystal after review+merge.

@Rangi42 Rangi42 closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mid-kid mid-kid

Labels
renaming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mid-kid @Rangi42