-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify more bit flags #120
Conversation
db056c5
to
07789db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the ton of work you did here. Sorry i've been AWOL lol. I promise I'll try to make some time this weekend at the latest to properly review the remaining items and approve this so we can get this merged. Thank you! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After these small changes I think we are good to merge! Thank you!
Pretty self-explanatory; a similar effort to some of the recent pokered commits.
Some things to note:
bit/res/set 7
s left, because of a convention to set the high bit of jumptable indexes to mean "exit the jumptable". I may add a genericEXIT_JUMPTABLE_F
constant in a separate PR.shift_const
macro to automatically define\1
(bit mask) and\1_F
(0-7 bit flag) constants. This does make it harder to grep forNAME_F
definitions, but otherwise we'd have a lot of redundant definition lines._F
or not. I usually went for local consistency, i.e. imitate nearby constant names.GetMovementPermissions
in home/map.asm sets theRIGHT
bit in all four directional cases. I may have made mistakes there, but AFAICT that's what the bit means.