Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Still reports "jsxBracketSameLine is deprecated." even when option is not used #428

Closed
smac89 opened this issue Dec 6, 2021 · 1 comment · Fixed by #430 or #431
Closed

Still reports "jsxBracketSameLine is deprecated." even when option is not used #428

smac89 opened this issue Dec 6, 2021 · 1 comment · Fixed by #430 or #431
Labels
released

Comments

@smac89
Copy link

smac89 commented Dec 6, 2021

  • prettier-eslint-cli 5.0.1:
  • prettier 2.5.0:
  • eslint 7.11.0:

Relevant code/config.

{
    "printWidth": 120,
    "tabWidth": 4,
    "bracketSameLine": false,
    "trailingComma": "es5"
}

What you did:

prettier-eslint "src/**/*.@(js|ts|jsx|tsx)" "cypress/**/*.@(ts|js)" --write --prettier-last

What happened:
I get a warning:

jsxBracketSameLine is deprecated.

Reproduction:

-- paste your link here --

Problem description:
The program reports the deprecation of the jsxBracketSameLine option, which I'm aware of. As you can see from the prettier config above, there is no jsxBracketSameLine option being used.

Suggested solution:
This program should respect the config for user-installed prettier and not produce such extraneous warnings.
@gwhitney gwhitney mentioned this issue Jan 29, 2022
Merged
gwhitney added a commit to gwhitney/prettier-eslint-cli that referenced this issue Jan 29, 2022
@gwhitney
fix: Don't specify any jsxBracketSameLine parameter if none is specified
d5cc3a0 
  By removing the default value for jsx-bracket-same-line (which is just
  `undefined` anyway), no option value at all for jsxBracketSameLine will
  be generated if none is specified. Then if a recent version of prettier
  is in use for which that option is deprecated, it won't complain.

  Resolves prettier#428.
gwhitney added a commit to gwhitney/prettier-eslint-cli that referenced this issue Jan 29, 2022
@gwhitney
fix: Don't specify any jsxBracketSameLine parameter if none is specified
aa6c3e2 
  By removing the default value for jsx-bracket-same-line (which is just
  `undefined` anyway), no option value at all for jsxBracketSameLine will
  be generated if none is specified. Then if a recent version of prettier
  is in use for which that option is deprecated, it won't complain.

  Resolves prettier#428.
@gwhitney gwhitney mentioned this issue Jan 29, 2022
Merged
@idahogurl idahogurl mentioned this issue Apr 28, 2022
Merged
idahogurl pushed a commit that referenced this issue May 11, 2022
@gwhitney
fix: Don't specify any jsxBracketSameLine parameter if none is specif…
04a8e04 
…ied (#430)

By removing the default value for jsx-bracket-same-line (which is just
  `undefined` anyway), no option value at all for jsxBracketSameLine will
  be generated if none is specified. Then if a recent version of prettier
  is in use for which that option is deprecated, it won't complain.

  Resolves #428.
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
1 participant
@smac89