-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 📦 Support ESLint 8 #431
Conversation
BREAKING CHANGE: Requires ESLint 8. ESLint 8 API changes caused the format function to now be asynchronous. Requires minimum Node 12 as required by ESLint 8
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 158 157 -1
Branches 23 23
=========================================
- Hits 158 157 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! love the energy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with 1 comment.
The configuration part might need proper testing to make sure eslint config file merging works properly, etc.
This new overrideConfigFile
option seems like it will use the provided config file only and not do any kind of merging with parent config files, etc.
@zimme Good catch! Further testing does need to be done. I just need to either add a test or test it on my own with a sample project. |
Blocked by prettier/prettier-eslint#745 to get the |
Thank you! For the record, this PR fixes
Is that right? |
@chrisbobbe Good catch! |
what a machine 🎉 |
Closes #427
Closes #428
What:
BREAKING CHANGE:
Requires ESLint 8. ESLint 8 API changes caused the format function to now be asynchronous.
Requires minimum Node 12 as required by ESLint 8