Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 📦 Support ESLint 8 #431

Merged
merged 9 commits into from
May 11, 2022
Merged

feat: 📦 Support ESLint 8 #431

merged 9 commits into from
May 11, 2022

Conversation

idahogurl
Copy link
Collaborator

@idahogurl idahogurl commented Apr 28, 2022

Closes #427
Closes #428

What:
BREAKING CHANGE:
Requires ESLint 8. ESLint 8 API changes caused the format function to now be asynchronous.
Requires minimum Node 12 as required by ESLint 8

Rebecca Vest added 2 commits April 27, 2022 16:22
BREAKING CHANGE:
Requires ESLint 8. ESLint 8 API changes caused the format function to now be asynchronous.
Requires minimum Node 12 as required by ESLint 8
@idahogurl idahogurl linked an issue Apr 28, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #431 (071b7fc) into master (afc22f5) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 071b7fc differs from pull request most recent head 54aa823. Consider uploading reports for the commit 54aa823 to get more accurate results

@@            Coverage Diff            @@
##            master      #431   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          158       157    -1     
  Branches        23        23           
=========================================
- Hits           158       157    -1     
Impacted Files Coverage Δ
src/format-files.js 100.00% <100.00%> (ø)
src/messages.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc22f5...54aa823. Read the comment docs.

@idahogurl idahogurl requested review from zimme and kylemh April 28, 2022 03:11
Copy link
Collaborator

@kylemh kylemh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! love the energy

Copy link
Member

@zimme zimme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with 1 comment.

The configuration part might need proper testing to make sure eslint config file merging works properly, etc.

This new overrideConfigFile option seems like it will use the provided config file only and not do any kind of merging with parent config files, etc.

@idahogurl
Copy link
Collaborator Author

@zimme Good catch! Further testing does need to be done. I just need to either add a test or test it on my own with a sample project.

@idahogurl
Copy link
Collaborator Author

Blocked by prettier/prettier-eslint#745 to get the overrideConfigFile option to work.

@idahogurl idahogurl merged commit 4e4077d into master May 11, 2022
@idahogurl idahogurl deleted the eslint-8-support branch May 11, 2022 16:18
@chrisbobbe
Copy link

@idahogurl
Copy link
Collaborator Author

@chrisbobbe Good catch!
Closes #303
Closes #304

@kylemh
Copy link
Collaborator

kylemh commented May 11, 2022

what a machine 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants