Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 가격 제안 모달 구현 #106

Merged
merged 7 commits into from
Oct 4, 2023
Merged

feat: 가격 제안 모달 구현 #106

merged 7 commits into from
Oct 4, 2023

Conversation

shinhyojeong
Copy link
Member

🔗 이슈 번호

⛳ 구현 사항

  • 가격 제안 모달 구현

📚 구현 설명

  • 스토리북이 열리지 않아 dev서버에서 테스트했습니다.
  • ds
    • Radio에 value prop이 없어 추가해야할 것 같습니다.
    • Button에 disabled에 대한 스타일이 적용되어있지 않아 수정이 필요할 것 같습니다.
  • 필수값에 대한 확인이 필요해 우선운 모든 값을 입력하도록 해놓았습니다 ! (디자이너 확인후 변경사항 반영 예정)

⏳ 실행 화면

입력 전

스크린샷 2023-08-19 오후 4 41 34

입력 후

스크린샷 2023-08-19 오후 6 21 02

택배 거래 선택시

스크린샷 2023-08-19 오후 6 22 08

@shinhyojeong shinhyojeong self-assigned this Aug 19, 2023
@shinhyojeong shinhyojeong requested a review from a team August 19, 2023 09:25
@shinhyojeong shinhyojeong added the feat 기능 추가, 삭제, 변경 label Aug 19, 2023
@shinhyojeong shinhyojeong force-pushed the feat/#101_price-offer-modal branch from 571319b to e68a05d Compare August 19, 2023 09:26
@shinhyojeong shinhyojeong force-pushed the feat/#101_price-offer-modal branch from a8d2b2b to 5ee81f9 Compare August 20, 2023 07:35
sonsurim
sonsurim requested changes Aug 23, 2023
View reviewed changes
Copy link
Member

@sonsurim sonsurim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스토리북 확인이 필요해서 #110 리뷰가 선행적으로 되어야 할 것 같습니다!
완료 되면 다시 확인 하겠습니다!

@shinhyojeong shinhyojeong force-pushed the feat/#101_price-offer-modal branch from 5ee81f9 to 8639373 Compare September 9, 2023 08:41
@shinhyojeong
Copy link
Member Author

@sonsurim @chojooyoung storybook 디버깅 받와왔숨다 확인 부탁드려용 ☺️~~~

chojooyoung
chojooyoung reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@chojooyoung chojooyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 확인 부탁드립니둥!

src/components/product/PriceOfferModal/index.tsx Outdated Show resolved Hide resolved
src/components/product/PriceOfferModal/index.tsx Outdated Show resolved Hide resolved
sonsurim
sonsurim reviewed Sep 28, 2023
View reviewed changes
src/components/product/PriceOfferModal/index.tsx Show resolved Hide resolved
src/components/product/PriceOfferModal/index.tsx Outdated Show resolved Hide resolved
src/components/product/PriceOfferModal/index.tsx Outdated Show resolved Hide resolved
src/components/product/PriceOfferModal/index.tsx Outdated Show resolved Hide resolved
src/components/product/PriceOfferModal/index.tsx Outdated Show resolved Hide resolved
src/components/product/PriceOfferModal/index.tsx Show resolved Hide resolved
src/components/product/PriceOfferModal/styled.ts Outdated Show resolved Hide resolved
src/components/product/PriceOfferModal/styled.ts Outdated Show resolved Hide resolved
src/components/product/PriceOfferModal/PriceOfferModal.stories.tsx Show resolved Hide resolved
src/components/product/PriceOfferModal/index.tsx Outdated Show resolved Hide resolved
@shinhyojeong shinhyojeong force-pushed the feat/#101_price-offer-modal branch from 8639373 to c247470 Compare September 29, 2023 14:44
@shinhyojeong shinhyojeong force-pushed the feat/#101_price-offer-modal branch from 983004a to 99fd7db Compare October 4, 2023 12:17
sonsurim
sonsurim approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@sonsurim sonsurim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍👍

고생많으셨습니당!!

@shinhyojeong shinhyojeong merged commit 65d0f79 into develop Oct 4, 2023
@shinhyojeong shinhyojeong deleted the feat/#101_price-offer-modal branch October 4, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chojooyoung chojooyoung chojooyoung left review comments

@sonsurim sonsurim sonsurim approved these changes

Assignees

@shinhyojeong shinhyojeong

Labels
feat 기능 추가, 삭제, 변경 Finish Code Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 가격 제안 모달 구현
3 participants
@shinhyojeong @sonsurim @chojooyoung