Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: storybook 에러 디버깅 #110

Merged
merged 2 commits into from
Aug 24, 2023
Merged

fix: storybook 에러 디버깅 #110

merged 2 commits into from
Aug 24, 2023

Conversation

sonsurim
Copy link
Member

🔗 이슈 번호

⛳ 구현 사항

  • storybook server, build 이슈를 해결 하였습니다.
    • 원인 : Storybook 6.5버전에서 defineProperty가 동작하지 않는 이슈
    • 해결 방안 : storybook에서 build, server를 띄울 때 사용되는 webpack의 next/image alias에 nextImageConfig를 등록

References

⏳ 실행 화면

AS-IS

image

TO-BE

image

@sonsurim sonsurim requested a review from a team August 22, 2023 11:43
@sonsurim sonsurim self-assigned this Aug 22, 2023
This was referenced Aug 23, 2023
Merged
Merged
@shinhyojeong
Copy link
Member

호옹 수정해주셨군요 넘나 수고하셨음둥 😝 LGTM~~~~~~~~

chojooyoung
chojooyoung approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@chojooyoung chojooyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!! ㅠㅠ

@sonsurim sonsurim merged commit 2883809 into develop Aug 24, 2023
@sonsurim sonsurim deleted the fix/#109-storybook branch August 24, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinhyojeong shinhyojeong shinhyojeong approved these changes

@chojooyoung chojooyoung chojooyoung approved these changes

Assignees

@sonsurim sonsurim

Labels
Finish Code Review fix 버그 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: storybook 에러 디버깅
3 participants
@sonsurim @shinhyojeong @chojooyoung