Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information matrix order in TORO file #76

Open
fokrey opened this issue Oct 11, 2024 · 0 comments
Open

Information matrix order in TORO file #76

fokrey opened this issue Oct 11, 2024 · 0 comments

Comments

@fokrey
Copy link

fokrey commented Oct 11, 2024

It appears that the information matrix order in the code example provided in FGraph_M3500.py is not following the correct format. The current implementation seems to serialize the information matrix in an incorrect order.

According to the standard serialization in the TORO and g20 formats, the information matrix should be serialized as the upper triangular part in row-major order. However, in the code, the order seems to be as follows: I11 I12 I22 I33 I13 I23. Adding information matrix in th correct order:

    # Serializing the information matrix and measurement
    self.toro_lines += f"EDGE_SE2 {origin} {target} {meas[0]:.6f} {meas[1]:.6f} {meas[2]:.6f} "
    self.toro_lines += f"{info[0, 0]:.6f} {info[0, 1]:.6f} {info[1, 1]:.6f} {info[2, 2]:.6f} {info[0, 2]:.6f} {info[1, 2]:.6f}\n"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant