Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'en' locale for accessibility improvements #46

Closed
tugcekucukoglu opened this issue Jan 18, 2023 · 1 comment · Fixed by #47
Closed

Update 'en' locale for accessibility improvements #46

tugcekucukoglu opened this issue Jan 18, 2023 · 1 comment · Fixed by #47
Assignees
@tugcekucukoglu
Labels
enhancement New feature or request

Comments

@tugcekucukoglu
Copy link
Member

Please check PrimeVue locale
@tugcekucukoglu tugcekucukoglu added the enhancement New feature or request label Jan 18, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 18, 2023
tugcekucukoglu added a commit that referenced this issue Jan 18, 2023
@tugcekucukoglu
Fixed #46 - Update 'en' locale for accessibility improvements
2cdb521
@melloware melloware mentioned this issue Jan 18, 2023
Merged
melloware pushed a commit that referenced this issue Jan 24, 2023
@tugcekucukoglu
Fixed #46 - Update 'en' locale for accessibility improvements (#47)
e2a8b39 
* Fixed #46 - Update 'en' locale for accessibility improvements

* Update README.md

* update for PrimeReact

* refactor for PrimeReact
ShiftcodeDream added a commit to ShiftcodeDream/primelocale that referenced this issue Jan 24, 2023
@ShiftcodeDream
Update fr locale (primefaces#46)
ed0f6b8
melloware pushed a commit that referenced this issue Jan 25, 2023
@ShiftcodeDream
French translation update (#51)
1bcf427 
* French translation

* Update fr locale (#46)

* Some adjsutments in french translations
@melloware
Copy link
Member

@tugcekucukoglu I am getting a lot of questions from translators about these values...

"slideNumber": "{slideNumber}",
 pageLabel: '{page}',

as these make no sense in a translation file as they look like replacement values of some sort? Can you explain what PrimeVue does with these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #46 - Update 'en' locale for accessibility improvements primefaces/primelocale
2 participants
@melloware @tugcekucukoglu