Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #46 - Update 'en' locale for accessibility improvements #47

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Fixed #46 - Update 'en' locale for accessibility improvements #47

merged 4 commits into from
Jan 24, 2023

Conversation

tugcekucukoglu
Copy link
Member

@tugcekucukoglu tugcekucukoglu commented Jan 18, 2023 •
edited by melloware
Loading

Fix #46 - Update 'en' locale for accessibility improvements

@melloware
Copy link
Member

It looks like you removed some options already in use in PrimeReact like "filter", "emptyMessage" etc.

melloware
melloware requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@melloware
Copy link
Member

Sorry it looks like just filter was removed but is used in PrimeReact here: https://github.com/primefaces/primereact/blob/1ccd212569e8a6474d33371a253e67c7cc7f0759/components/lib/datatable/ColumnFilter.js#L391-L413

@tugcekucukoglu
Copy link
Member Author

I guess I also miss custom.

@melloware
Copy link
Member

I did a search I didn't find "custom" anywhere in PrimeREact so that one might be safe to remove?

@tugcekucukoglu
Copy link
Member Author

It seems custom is an outdated locale. In any case, PrimeReact team will have decided its future. Personally, I prefer it to stay.

@melloware
Copy link
Member

No problem thanks for the updates!

@melloware melloware merged commit e2a8b39 into main Jan 24, 2023
@melloware melloware deleted the accessibility-updates branch July 28, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update 'en' locale for accessibility improvements
2 participants
@tugcekucukoglu @melloware