Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EffectDuration is ignored in Galleria #5345

Closed
yacafx opened this issue Mar 14, 2018 · 2 comments
Closed

EffectDuration is ignored in Galleria #5345

yacafx opened this issue Mar 14, 2018 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@yacafx
Copy link

yacafx commented Mar 14, 2018

[X ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
When I try to set the effect attribute as indicate at documentation, this doesn't work and I receive the
missing property error

ERROR in : Can't bind to 'effect' since it isn't a known property of 'p-galleria'.
1. If 'p-galleria' is an Angular component and it has 'effect' input, then verify that it is part of this module.
2. If 'p-galleria' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress this message.
3. To allow any property add 'NO_ERRORS_SCHEMA' to the '@NgModule.schemas' of this component. ("<p-galleria [images]="images" [ERROR ->][effect]="slide" [styleClass]="'homeCarousel'" [autoPlay]="true" [showCaption]="false" [showFilmstrip")

I use the Galleria like this:

<p-galleria [images]="images" [effect]="slide" [styleClass]="'homeCarousel'" [autoPlay]="true" [showCaption]="false" [showFilmstrip]="false"></p-galleria>

At App.module I have imported the module corectly

import { GalleriaModule } from 'primeng/primeng';
...

imports: [
     ...
     GalleriaModule
]

I have already reviewed the component code and I can't see the effect property, instead I see the fade effect hardcoded

@jupin-r
Copy link
Contributor

jupin-r commented Mar 14, 2018

You are right. There is no property effect and effectDuration in galleria widget. I think this is a documentation bug.

BTW: The documentation of Galleria widget also does not include the description of property styleClass.

cagataycivici added a commit that referenced this issue Mar 28, 2018
@cagataycivici
Copy link
Member

PR merged.

@cagataycivici cagataycivici self-assigned this Mar 28, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 28, 2018
@cagataycivici cagataycivici added this to the 5.2.4 milestone Mar 28, 2018
@cagataycivici cagataycivici changed the title Can't set effects to Galleria component EffectDuration is ignored in Galleria Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants