Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement effectDuration for Galleria #5363

Merged

Conversation

ttweaver
Copy link

Partial fix for issue #5345. Added input variable effectDuration disclosed in documentation, but not available. Set default to existing value in code. Although documentation states default value of 250. Passed new input variable to domHandler.fadeIn().

…Added input variable to domHandler.fadeIn function.
@cagataycivici cagataycivici changed the title #5345 - Can't set effects to Galleria component Implement effectDuration for Galleria Mar 28, 2018
@cagataycivici cagataycivici self-assigned this Mar 28, 2018
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 28, 2018
@cagataycivici cagataycivici added this to the 5.2.4 milestone Mar 28, 2018
@cagataycivici cagataycivici merged commit f2c5221 into primefaces:master Mar 28, 2018
@cagataycivici cagataycivici removed this from the 5.2.4 milestone Mar 28, 2018
@ttweaver ttweaver deleted the #5345-Galleria-Properties-Missing branch March 28, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants