Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add additional rails to guard against crashes #1009

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

NQuinn27
Copy link
Contributor

@NQuinn27 NQuinn27 commented Oct 2, 2024

Description

PRMSUP-2746

This one I couldnt reproduce well, but I believe these changes will help guard against the kinds of crashes in the ticket.

Other Notes

  • Other changes that are not specifically related to the intent of the PR

Manual Testing

Add manual testing notes here if applicable, otherwise remove this section

Screenshots

If applicable, otherwise remove this section

Contributor Checklist

  • All status checks have passed prior to code review
  • I have added unit tests to a reasonable level of coverage where suitable
  • I have added UI tests to new user flows, if applicable
  • I have manually tested newly added UX
  • I have open a documentation PR, if applicable

Reviewer Checklist

  • I have verified that a suitable set of automated tests has been added
  • I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR
  • I have verified the documentation PR aligns with this PR, if applicable

Before Merging

  • If introducing a breaking change, I have communicated it internally
  • Any related documentation PRs are ready to merge

Other Stuff

  • You can find out more about our automation checks here
  • Find out more about conventional commits here

@NQuinn27 NQuinn27 requested a review from a team as a code owner October 2, 2024 13:15
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against 6572eab

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Copy link

sonarcloud bot commented Oct 2, 2024

@NQuinn27 NQuinn27 merged commit 8fd81a4 into master Oct 2, 2024
14 checks passed
@NQuinn27 NQuinn27 deleted the nq/cleanup_crash branch October 2, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants