Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Group focus rings are busted #600

Closed
shawnbot opened this issue Nov 15, 2018 · 0 comments · Fixed by #588
Closed

Button Group focus rings are busted #600

shawnbot opened this issue Nov 15, 2018 · 0 comments · Fixed by #588
Assignees
@shawnbot
Labels
patch release ⭐️rep an industry leading reputation status: investigate

Comments

@shawnbot
Copy link
Contributor

As you can see live in the style guide, all focused buttons except the last one have their focus rings cut off by the next one:

image

image

Maybe we could fix this with position: relative and z-index: 1, but that might cause issues with existing instances of button groups on github.com.
@shawnbot shawnbot self-assigned this Nov 15, 2018
shawnbot added a commit that referenced this issue Nov 15, 2018
@shawnbot
add z-index: 1 to active button group items
a14762d 
fixes #600
@shawnbot shawnbot mentioned this issue Nov 15, 2018
Merged
@shawnbot shawnbot mentioned this issue Nov 15, 2018
Merged
19 tasks
shawnbot added a commit that referenced this issue Nov 19, 2018
@shawnbot
fix #600 again
32be065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnbot shawnbot

Labels
patch release ⭐️rep an industry leading reputation status: investigate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 10.10.0 primer/css
1 participant
@shawnbot