-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 10.10.0 #588
Merged
Merged
Release 10.10.0 #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `max-width` instead of `width` allows the blankslate to shrink on smaller screens. Resolves #553.
All other flavors of `.container` use max-width to respond on smaller screens. Applying this to base `.container`.
The stylelint-config-github installation step isn't necessary anymore.
Merged
Button Group fixes
Add Progress component
- primer-alerts@1.5.11 - primer-avatars@1.5.8 - primer-base@1.9.0 - primer-blankslate@1.5.0 - primer-box@2.5.11 - primer-branch-name@1.0.9 - primer-breadcrumb@1.5.7 - primer-buttons@2.6.2 - primer-core@6.10.5 - primer-forms@2.1.6 - primer-labels@1.5.11 - primer-layout@1.6.0 - primer-markdown@3.7.11 - primer-marketing-buttons@1.0.11 - primer-marketing-support@1.5.4 - primer-marketing-type@1.4.11 - primer-marketing-utilities@1.7.1 - primer-marketing@6.3.1 - primer-navigation@1.5.9 - primer-page-headers@1.5.1 - primer-page-sections@1.5.1 - primer-pagination@1.0.5 - primer-popover@0.1.6 - primer-product@5.8.0 - primer-progress@0.1.0 - primer-subhead@1.0.9 - primer-support@4.7.0 - primer-table-object@1.4.11 - primer-tables@1.5.1 - primer-tooltips@1.5.9 - primer-truncate@1.4.11 - primer-utilities@4.14.0 - primer@10.10.0 - generator-primer-module@1.2.0 - primer-module-build@1.0.7 - stylelint-config-primer@3.0.0 - stylelint-selector-no-utility@2.0.0
FYI, this is blocked on some button group issues that @jonrohan discovered in Safari. |
Reverting primer-buttons flex group
Button group focus ring fix (again)
jonrohan
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS changes look good. It's hard to gauge the workflow stuff until we use it so and we'll iterate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primer Minor Release
Tracking Issue for next minor release: 📦 10.10.0
Approximate release date: 📆 10/24/18
🚀 New features
hidden
docs, make[hidden] { display: none; }
more specific Add HTML hidden attribute docs, increase [hidden] selector specificity #561(reverted).container
is now responsive, thanks to @crhallberg in Make .container responsive #571.blankslate-narrow
is also responsive, thanks to @crhallberg in Bugfix: Make blankslate-narrow responsive #570 (fixes Narrow blankslate does not work well on mobile #553)🐛 Bug fixes
fs-extra
as dependency ofprimer-module-build
Add fs-extra to primer-module-build.dependencies #591primer-utilities
fromstylelint-selector-no-utility
in Fix primerize, add "fresh" run-script, etc. #597💅 Housekeeping
--dry-run
flag to re-enable release candidate publishing per Minor Release Tracking PR 10.9.0 #556 (comment)package-lock.json
files from git, and generally smooth out workflow speed bumps in Fix primerize, add "fresh" run-script, etc. #597script/bump-rc
📝 Documentation
Ship checklist
Update primer.github.io(no longer necessary)/cc @primer/ds-core