Add HTML hidden attribute docs, increase [hidden] selector specificity #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muan
reviewed
Aug 24, 2018
shawnbot
changed the title
shawnbot
changed the title
shawnbot
added
status: review needed
Tag: Enhancement
Tag: Documentation
and removed
status: wip
Tag: Documentation
labels
shawnbot
changed the title
jonrohan
requested changes
Nov 13, 2018
There was a problem hiding this comment.
Instead of adding this base style to the utilities section, you can double up the [hidden] selector in primer-base
Example:
[hidden][hidden] { display: none !important; }
.d-block { display: block !important; }In this example [hidden] will override d-block even if they're both applied. Here's a codepen example https://codepen.io/jonrohan/pen/QJdVVY toggle the hidden prop on the <div
shawnbot
changed the title
/cc @jonrohan — I did this here rather than in normalize.scss because I didn't want to lose it if we ever update that file again.
shawnbot
commented
Nov 13, 2018
chalkygames123
added a commit
to chalkygames123/front-end-template
that referenced
this pull request
Feb 8, 2022
This was referenced Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our display utility docs (rendered: before, after) to include a section about using the HTML
hiddenattribute with the utility classes. I've also added a heading for thedisplay: tablewrapping bug note to separate it out from the new section.The new section links to the now-missing
v10.9.0v10.10.0 release notes, which should exist once we publish the release via #556.@muan, I'd love your input on this! 🙇