Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Make blankslate-narrow responsive #570

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Bugfix: Make blankslate-narrow responsive #570

merged 3 commits into from
Oct 24, 2018

Conversation

crhallberg
Copy link

Using max-width instead of width allows the blankslate to shrink on smaller screens.

Fixes: #553.

Sorry for the branch name, I made this change right on GitHub.

/cc @primer/ds-core

Using `max-width` instead of `width` allows the blankslate to shrink on smaller screens.

Resolves #553.
@crhallberg
Copy link
Author

It's also possible that .container could benefit from the same adjustment: https://github.com/primer/primer/blob/master/modules/primer-layout/lib/container.scss#L4.

The other container flavors are using max-width so it would also be more consistent.

@shawnbot shawnbot changed the base branch from master to release-10.9.0 October 5, 2018 23:50
@shawnbot shawnbot changed the base branch from release-10.9.0 to release-11.0.0 October 5, 2018 23:51
@shawnbot
Copy link
Contributor

shawnbot commented Oct 5, 2018

Thanks for this, @crhallberg! I'm queueing this up for our v11 release in #498. We need to catch that branch up to some of the minor version work that's been done since we opened it, so don't worry about merge conflicts for now. ✌️

@crhallberg
Copy link
Author

Sure thing, @shawnbot! Would it be helpful to make another pull request for the .container width to max-width adjustment I mentioned earlier?

@shawnbot
Copy link
Contributor

shawnbot commented Oct 9, 2018

@crhallberg Sure, that'd be great. Thanks!

@shawnbot shawnbot changed the base branch from release-11.0.0 to release-10.9.0 October 17, 2018 20:19
@shawnbot shawnbot changed the base branch from release-10.9.0 to release-10.10.0 October 23, 2018 21:30
@shawnbot
Copy link
Contributor

FYI, I've decided to include this as an enhancement in v10.10.0 rather than a breaking change. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants