Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving segmented_control.css to primer_view_components #2208

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Moving segmented_control.css to primer_view_components #2208

merged 2 commits into from
Aug 18, 2022

Conversation

jonrohan
Copy link
Member

What are you trying to accomplish?

I would like to move this component to Primer View Components. primer/view_components#1225

We haven't begun to use this anywhere and it's not documented on the site yet, so I'm classifying this as a patch.

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@jonrohan jonrohan requested a review from a team as a code owner August 17, 2022 19:45
@jonrohan jonrohan requested a review from langermank August 17, 2022 19:45
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 8d0161d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan mentioned this pull request Aug 17, 2022
Closed
1 task
@github-actions github-actions bot temporarily deployed to Storybook Preview August 17, 2022 19:52 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview August 17, 2022 19:52 Inactive
mperrotti
mperrotti approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@mperrotti mperrotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, but I don't understand how we decide when styles should live in PCSS vs PVC. Could you point me to docs or help me understand?

Approval is assuming that this is in fact a patch and not a major release.

.changeset/cuddly-months-greet.md
@@ -0,0 +1,5 @@
---
"@primer/css": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this technically a breaking change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you could say so, but I'm operating under this assumption:

We haven't begun to use this anywhere and it's not documented on the site yet, so I'm classifying this as a patch.

The code was added to this repository specifically for the view component which isn't complete yet.

@jonrohan
Copy link
Member Author

Could you point me to docs or help me understand?

It's a bit of an early test, I started an ADR here primer/view_components#1319

@jonrohan jonrohan merged commit 83e4348 into main Aug 18, 2022
@jonrohan jonrohan deleted the remove_segmented_control branch August 18, 2022 01:58
@primer-css primer-css mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti approved these changes

@langermank langermank Awaiting requested review from langermank langermank was automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @mperrotti