Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving segmented_control.css to primer_view_components #2208

Merged
merged 2 commits into from
Aug 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cuddly-months-greet.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this technically a breaking change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you could say so, but I'm operating under this assumption:

We haven't begun to use this anywhere and it's not documented on the site yet, so I'm classifying this as a patch.

The code was added to this repository specifically for the view component which isn't complete yet.

---

Moving segmented_control.css to primer_view_components

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion src/core/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
@import '../links/index.scss';
@import '../navigation/index.scss';
@import '../pagination/index.scss';
@import '../segmented-control/index.scss';
@import '../tooltips/index.scss';
@import '../truncate/index.scss';
@import '../overlay/index.scss';
Expand Down
25 changes: 0 additions & 25 deletions src/segmented-control/README.md

This file was deleted.

3 changes: 0 additions & 3 deletions src/segmented-control/index.scss

This file was deleted.

167 changes: 0 additions & 167 deletions src/segmented-control/segmented-control.scss

This file was deleted.